Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 14.12.01, 16.11.01
    • Component/s: framework
    • Labels:
      None

      Description

      in a CI setup the cache of ivy needs to be cleared occasionaly in order to retrieve correct files.

        Activity

        Hide
        pfm.smits Pierre Smits added a comment -

        This patch fixes the issue.

        Show
        pfm.smits Pierre Smits added a comment - This patch fixes the issue.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Pierre,

        Fast review: did you purposedly added (a lot of) things in ivy.xml? Also I guess you inadvertenly removed a part of run-tests-with-cobertura target, and added few useless minor changes.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Pierre, Fast review: did you purposedly added (a lot of) things in ivy.xml? Also I guess you inadvertenly removed a part of run-tests-with-cobertura target, and added few useless minor changes.
        Hide
        pfm.smits Pierre Smits added a comment -

        Hmm.

        I must have gotten confused and made some mistakes there.

        I will do a new patch file.

        Show
        pfm.smits Pierre Smits added a comment - Hmm. I must have gotten confused and made some mistakes there. I will do a new patch file.
        Hide
        pfm.smits Pierre Smits added a comment -

        This patch resolves both this issue and issue OFBIZ-5462

        Show
        pfm.smits Pierre Smits added a comment - This patch resolves both this issue and issue OFBIZ-5462
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre,

        Your slightly modified patch is in trunk at revision: 1556166

        I also added activemq (recently added) in the clean-downloads target

        Then in r1556174
        I fixed a long time pending minor issue when deleting downloaded jar files in Windows (were not deleted). Using deleteonexit did the
        trick (but saw later not for all), also added verbose to see which downloaded jar files are deleted and uncommented the clean-downloads sub-target in the clean-all target, and added a description to clean-ivy

        About the not deleted jar, I found this link useful http://raibledesigns.com/rd/entry/ant_won_t_delete_a

        Last note: mysql was missing in clean-downloads target added at r1556185

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your slightly modified patch is in trunk at revision: 1556166 I also added activemq (recently added) in the clean-downloads target Then in r1556174 I fixed a long time pending minor issue when deleting downloaded jar files in Windows (were not deleted). Using deleteonexit did the trick (but saw later not for all), also added verbose to see which downloaded jar files are deleted and uncommented the clean-downloads sub-target in the clean-all target, and added a description to clean-ivy About the not deleted jar, I found this link useful http://raibledesigns.com/rd/entry/ant_won_t_delete_a Last note: mysql was missing in clean-downloads target added at r1556185
        Hide
        chrisg Christian Geisert added a comment -

        This change causes unnecessary long build time when using Ivy (and cleans the global Ivy cache, not just the OFBiz related stuff). I think 'clean' should just delete the build artefacts.
        When you need to clear the Ivy cache just use the 'clean-ivy'' target.

        Show
        chrisg Christian Geisert added a comment - This change causes unnecessary long build time when using Ivy (and cleans the global Ivy cache, not just the OFBiz related stuff). I think 'clean' should just delete the build artefacts. When you need to clear the Ivy cache just use the 'clean-ivy'' target.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Good idea Christian, will you submit something?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Good idea Christian, will you submit something?
        Hide
        chrisg Christian Geisert added a comment -

        Ok, I'll commit the change (removing <ivy:cleancache/> from <target name="clean">)

        Show
        chrisg Christian Geisert added a comment - Ok, I'll commit the change (removing <ivy:cleancache/> from <target name="clean">)
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Will you not provide an "ant clean-ivy" target?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Will you not provide an "ant clean-ivy" target?
        Hide
        pfm.smits Pierre Smits added a comment -

        Beware that <antcall target="clean-ivy"/> is called within the 'clean-all' target and the 'clean-downloads' target.

        And the clean-downloads target is also called in the clean-all target.

        Jacques Le Roux The target 'clean-ivy' already exists.

        Show
        pfm.smits Pierre Smits added a comment - Beware that <antcall target="clean-ivy"/> is called within the 'clean-all' target and the 'clean-downloads' target. And the clean-downloads target is also called in the clean-all target. Jacques Le Roux The target 'clean-ivy' already exists.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Ha sorry, I should have looked at it. I thought <ivy:cleancache/> was only harcoded there. Now that I look at it I should not indeed not have let that passed. At least an <antcall target="clean-ivy"/> should have been used there.

        OK, Christian while a it I remove it, thanks for spotting that!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Ha sorry, I should have looked at it. I thought <ivy:cleancache/> was only harcoded there. Now that I look at it I should not indeed not have let that passed. At least an <antcall target="clean-ivy"/> should have been used there. OK, Christian while a it I remove it, thanks for spotting that!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Done in
        trunk r1734276
        R15.12 r1734277
        R14.12 r1734278

        Show
        jacques.le.roux Jacques Le Roux added a comment - Done in trunk r1734276 R15.12 r1734277 R14.12 r1734278

          People

          • Assignee:
            chrisg Christian Geisert
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development