Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5416

Sales order cart items already assigned to ship groups are incorrectly able to be modified to quantities/prices that break the ProductStoreShipmentMeth rules

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 14.12.01, 12.04.06, 13.07.02
    • Component/s: order
    • Labels:
      None

      Description

      When modifying sales order cart items that already have been assigned to ship groups, no logic exists to check that the modifications follow the ProductStoreShipmentMeth quantity/price rules of the shipment method.

      To reproduce:
      1. Add a maxTot of 16 to productStoreShipmentMethId=9016 (FEDEX/Ground Home Delivery) on the Catalog->Store->Shipping page
      2. Create a sales order for DemoCustCompany
      3. Add 1 GZ-1000 to the cart and notice the total is under 16
      4. Finalize the cart until reaching the shipping options page
      5. Choose the "FedEx Home Delivery" option and click "Continue"
      6. Click "Cart Items" to return to the cart page
      7. Change the quantity of GZ-1000 to 2 and click "Recalculate Order"
      8. Notice the total price of the cart has exceeded the 16 but the shipment method is still associated with the ship group

      Logic needs to be added to do something such as remove the shipment methods from ship groups when modifications of associated order items violate their rules. This would cause the shipping options page to reappear for entry of required missing ship group shipment methods when the "Finalize" button is clicked.

      Another option would be to keep the shipment method and throw an error when modifications violate ship group rules.

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          R13.07 r1639917
          R12.04 r1639918

          Show
          jacques.le.roux Jacques Le Roux added a comment - R13.07 r1639917 R12.04 r1639918
          Hide
          toashishvijay Ashish Vijaywargiya added a comment -

          Thanks Christian for reporting the issue and Thanks Arun for providing the patch. Changes are committed in trunk at r1639835.

          Show
          toashishvijay Ashish Vijaywargiya added a comment - Thanks Christian for reporting the issue and Thanks Arun for providing the patch. Changes are committed in trunk at r1639835.
          Hide
          arunpati Arun Patidar added a comment -

          I was able to regenerate the issue, thanks for the steps.

          Please find attached patch, I set shipmentMethodTypeId to null whenever cart get recalculate and update so that user have shipping options to select on finalize order.

          Show
          arunpati Arun Patidar added a comment - I was able to regenerate the issue, thanks for the steps. Please find attached patch, I set shipmentMethodTypeId to null whenever cart get recalculate and update so that user have shipping options to select on finalize order.
          Hide
          ofbizzer Christian Carlow added a comment -

          This bug occurs when updating ship group information for existing sales orders as well. Ship groups are able to be reassigned shipment methods for which rules are violated by assigned order items. I'm not sure if this should be considered a separate issue yet.

          Show
          ofbizzer Christian Carlow added a comment - This bug occurs when updating ship group information for existing sales orders as well. Ship groups are able to be reassigned shipment methods for which rules are violated by assigned order items. I'm not sure if this should be considered a separate issue yet.

            People

            • Assignee:
              toashishvijay Ashish Vijaywargiya
              Reporter:
              ofbizzer Christian Carlow
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development