[OFBIZ-5325] Deprecate doCacheClear in Delegator interface and class and related minilang classes

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk
• Fix Version/s: 14.12.01, 12.04.06, 13.07.02
• Component/s: ALL COMPONENTS, framework
• Assignee: Jacques Le Roux
• Reporter: Jacques Le Roux
• Created: 18/Sep/13 17:33
• Updated: 21/Dec/14 13:00
• Resolved: 21/Dec/14 12:48

Description

At http://svn.apache.org/viewvc?view=revision&revision=r1476296 Adrian noted:

I updated the Delegator JavaDocs to warn against skipping the cache clearing step - which shouldn't be done

After I proposed to rather refactor it, Paul Foxworthy suggested:

If doCacheClear will have no effect, I suggest deprecating the method
signature with the doCacheClear. It can call another overloaded variant
without that parameter. All calls in trunk should be changed to the second.
We can leave the deprecated version for backwards compatibility for a time.

I agree in the release branches that all we should do is add some JavaDoc
and log a warning.

I agree with Paul, and here is how I will do it:

1. Deprecate in trunk
2. Backport in releases
3. Remove useless deprecated in trunk