Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5325

Deprecate doCacheClear in Delegator interface and class and related minilang classes

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk
    • Fix Version/s: 14.12.01, 12.04.06, 13.07.02
    • Component/s: ALL COMPONENTS, framework
    • Labels:
      None

      Description

      At http://svn.apache.org/viewvc?view=revision&revision=r1476296 Adrian noted:

      I updated the Delegator JavaDocs to warn against skipping the cache clearing step - which shouldn't be done

      After I proposed to rather refactor it, Paul Foxworthy suggested:

      If doCacheClear will have no effect, I suggest deprecating the method
      signature with the doCacheClear. It can call another overloaded variant
      without that parameter. All calls in trunk should be changed to the second.
      We can leave the deprecated version for backwards compatibility for a time.

      I agree in the release branches that all we should do is add some JavaDoc
      and log a warning.

      I agree with Paul, and here is how I will do it:

      1. Deprecate in trunk
      2. Backport in releases
      3. Remove useless deprecated in trunk

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Commited in trunk at r1524704, will be backported to releases after OFBIZ-4794. I will then manually add log warnings as suggested by Paul...

        Show
        jacques.le.roux Jacques Le Roux added a comment - Commited in trunk at r1524704, will be backported to releases after OFBIZ-4794 . I will then manually add log warnings as suggested by Paul...
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Backported in
        R13.07 r1647120
        R12.04 r1647121

        Show
        jacques.le.roux Jacques Le Roux added a comment - Backported in R13.07 r1647120 R12.04 r1647121
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        I removed the deprecated and useless stuff in trunk at revision: 1647132

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited I removed the deprecated and useless stuff in trunk at revision: 1647132

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jacques.le.roux Jacques Le Roux
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development