Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5295

Anonymous Quick Checkout: No Payment Method Information shown in Order Confirmation

    Details

    • Sprint:
      Bug Crush Event - 21/2/2015, Community Day 1 - 2015

      Description

      Using Anonymous Quick Checkout no payment method information is shown in the Order Confirmation screen, i.e. the respective screenlet remains completely empty. The two payment methods present in the shop are EFT_ACCOUNT and EXT_OFFLINE. Anonymous (long 6 step) Check Out and all check out variants with logged in user are working.

      1. OFBIZ-5295.patch
        2 kB
        Yashwant Dhakad

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Using the "Billing address is the same as the shipping address" option I get this error message in screen "method not handled paymentMethodTypeId : " though I chose CC. If I fill the Billing address all go well. SO it seems to me your issue could be related with this option, please confirm

        Show
        jacques.le.roux Jacques Le Roux added a comment - Using the "Billing address is the same as the shipping address" option I get this error message in screen "method not handled paymentMethodTypeId : " though I chose CC. If I fill the Billing address all go well. SO it seems to me your issue could be related with this option, please confirm
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Note that the last screen keep getting blank, this is known: OFBIZ-5304

        Show
        jacques.le.roux Jacques Le Roux added a comment - Note that the last screen keep getting blank, this is known: OFBIZ-5304
        Hide
        komdata Sebastian Wachinger added a comment - - edited

        Thank you for your input, I will try to reproduce the behaviour you described.

        The bug I reported is in Anonymous Quick Checkout aka Anonymous Checkout 3 steps, and in the meantime I found out what caused it:
        In r1044503 the migration was done from the Dojo toolkit to jQuery, and in both the two files relevant for this bug (quickAnonOptionSettings.ftl and quickAnonPaymentInformation.ftl) there are still remnants of the former Dojo version present:
        The function aroundSubmitOrder(invocation) that used to be called by the since deleted line dojo.event.connect("around", "processOrder", "aroundSubmitOrder"); is not called anymore*, hence the payment method (and the shipping method) selected in step 2 quickAnonProcessCustomerSettings are not processed in the Order Confirmation screen.

        I am not aware of the issue recently reported in OFBIZ-5304 and do think it is not related to this one, but will check it out
        anyway.

        *as is aroundOptSubmitOrder(invocation) in quickAnonOptionSettings.ftl

        Show
        komdata Sebastian Wachinger added a comment - - edited Thank you for your input, I will try to reproduce the behaviour you described. The bug I reported is in Anonymous Quick Checkout aka Anonymous Checkout 3 steps , and in the meantime I found out what caused it: In r1044503 the migration was done from the Dojo toolkit to jQuery, and in both the two files relevant for this bug ( quickAnonOptionSettings.ftl and quickAnonPaymentInformation.ftl ) there are still remnants of the former Dojo version present: The function aroundSubmitOrder(invocation) that used to be called by the since deleted line dojo.event.connect("around", "processOrder", "aroundSubmitOrder"); is not called anymore*, hence the payment method (and the shipping method) selected in step 2 quickAnonProcessCustomerSettings are not processed in the Order Confirmation screen. I am not aware of the issue recently reported in OFBIZ-5304 and do think it is not related to this one, but will check it out anyway. *as is aroundOptSubmitOrder(invocation) in quickAnonOptionSettings.ftl
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Sebastian,

        Yes, OFBIZ-5304 is totally unrelated and already assigned to the culprit

        If you get a chance please submit a patch for the case you spotted.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Sebastian, Yes, OFBIZ-5304 is totally unrelated and already assigned to the culprit If you get a chance please submit a patch for the case you spotted.
        Hide
        komdata Sebastian Wachinger added a comment - - edited

        I managed to fix the issue for now, but I'd regard my solution rather a quick and dirty hack than something worthy to be in the OFBiz codebase. Anyway I'll post it here asap.

        (As a side note I'd rather see the Anonymous Quick Checkout programmed more the way Quick Checkout is done, i.e. with the amount of client side jQuery wizardry reduced to the max.

        I know there has been plenty of discussion on this topic, and sure I'm a big fan of jQuery myself (and glad that ofbiz moved to this toolkit), but those very checkout pages are the place where the fate of any B2C webshop is sealed, so why take any chances here instead of resorting to a maybe less elegant but more robust server side solution.
        The original dojo.connect() method itself is deprecated now as are some older jQuery methods that have been replaced by jQuery.on(), so I'd rather avoid keeping up with all those changes in crucial places if possible.

        I'm a new member of the great OFBiz community, so if I rehash an old worn-out issue here please disregard this part.)

        Show
        komdata Sebastian Wachinger added a comment - - edited I managed to fix the issue for now, but I'd regard my solution rather a quick and dirty hack than something worthy to be in the OFBiz codebase. Anyway I'll post it here asap. (As a side note I'd rather see the Anonymous Quick Checkout programmed more the way Quick Checkout is done, i.e. with the amount of client side jQuery wizardry reduced to the max. I know there has been plenty of discussion on this topic, and sure I'm a big fan of jQuery myself (and glad that ofbiz moved to this toolkit), but those very checkout pages are the place where the fate of any B2C webshop is sealed, so why take any chances here instead of resorting to a maybe less elegant but more robust server side solution. The original dojo.connect() method itself is deprecated now as are some older jQuery methods that have been replaced by jQuery.on(), so I'd rather avoid keeping up with all those changes in crucial places if possible. I'm a new member of the great OFBiz community, so if I rehash an old worn-out issue here please disregard this part.)
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Actually, when possible, I'm all for plain old javascript It's just a matter of human ressources. If you are able to provide something simpler, I'm sure we will consider it with attention...

        Show
        jacques.le.roux Jacques Le Roux added a comment - Actually, when possible, I'm all for plain old javascript It's just a matter of human ressources. If you are able to provide something simpler, I'm sure we will consider it with attention...
        Hide
        komdata Sebastian Wachinger added a comment -

        Actually, when possible, I'm all for plain old javascript

        Good to know! I'll try and refactor the Anonymous Quick Checkout later on in a more robust fashion, after all this would be a nice opportunity to give something back to the community

        Show
        komdata Sebastian Wachinger added a comment - Actually, when possible, I'm all for plain old javascript Good to know! I'll try and refactor the Anonymous Quick Checkout later on in a more robust fashion, after all this would be a nice opportunity to give something back to the community
        Hide
        yashwant.dhakad Yashwant Dhakad added a comment -

        Here is the patch for issue.

        Show
        yashwant.dhakad Yashwant Dhakad added a comment - Here is the patch for issue.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Thanks Sebastian Wachinger for reporting the issue.
        Thanks Yashwant for the patch.
        Committed in:

        Trunk at r#1668265
        R14.12 at r#1668266
        R13.07 at r#1668268
        R12.04 at r#1668269

        Show
        deepak.dixit Deepak Dixit added a comment - Thanks Sebastian Wachinger for reporting the issue. Thanks Yashwant for the patch. Committed in: Trunk at r#1668265 R14.12 at r#1668266 R13.07 at r#1668268 R12.04 at r#1668269

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            komdata Sebastian Wachinger
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile