Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5225

The Invoice Item type dropdown have same description for different invoiceItemTypeId.

Details

    • Wish
    • Status: Closed
    • Minor
    • Resolution: Incomplete
    • Release Branch 10.04, Release Branch 11.04, Release Branch 12.04, Trunk
    • Release Branch 10.04, Trunk
    • accounting
    • None

    Description

      The Invoice Item type dropdown have same description for different invoiceItemTypeId on Agreement Terms page in accounting.

      https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=10000

      The description should be different that the invoiceItemType is for sales or purchase.
      Eg: Invoice Fee(Sales)
      Invoice Fee(Purchase)

      Something to differentiate between the same description.

      Attachments

        1. OFBIZ-5225.patch
          17 kB
          Ankit Jain
        2. Updated-OFBIZ-5225.patch
          48 kB
          Ankit Jain

        Issue Links

          Activity

            ankit.jain Ankit Jain added a comment -

            Attached a patch, modified the description for Invoice Item Type.

            Thanks

            ankit.jain Ankit Jain added a comment - Attached a patch, modified the description for Invoice Item Type. Thanks

            Hi Ankit, this is a good initiative, but remember OFBiz is a localised sofware. So please rather provide labels. For other languages, you might simply (Sales) or (Purchase) also in labels. The purchase labels have a P before the last part, like PINV_ADD_FEATURE instead of INV_ADD_FEATURE for sales. Then people will contribute the translations if they want...

            Thanks!

            jleroux Jacques Le Roux added a comment - Hi Ankit, this is a good initiative, but remember OFBiz is a localised sofware. So please rather provide labels. For other languages, you might simply (Sales) or (Purchase) also in labels. The purchase labels have a P before the last part, like PINV_ADD_FEATURE instead of INV_ADD_FEATURE for sales. Then people will contribute the translations if they want... Thanks!
            ankit.jain Ankit Jain added a comment -

            Thanks Jacques, for the suggestion.

            Here is the updated the patch.

            ankit.jain Ankit Jain added a comment - Thanks Jacques, for the suggestion. Here is the updated the patch.

            Thanks Ankit,

            Please update your working copy, I got some fuzz.

            Your patch is in
            trunk r1494682

            I will backport later, I want to do OFBIZ-4794 before...

            jleroux Jacques Le Roux added a comment - Thanks Ankit, Please update your working copy, I got some fuzz. Your patch is in trunk r1494682 I will backport later, I want to do OFBIZ-4794 before...
            ankit.jain Ankit Jain added a comment -

            Thanks Jacques

            ankit.jain Ankit Jain added a comment - Thanks Jacques
            hansbak Hans Bakker added a comment -

            i am only wondering here if the drop down of the agreement is usefull? shouldn't we separate it for sales/purchase/payrol and other types of invoices anyway...

            hansbak Hans Bakker added a comment - i am only wondering here if the drop down of the agreement is usefull? shouldn't we separate it for sales/purchase/payrol and other types of invoices anyway...

            Maybe, I did not question it, another task...

            jleroux Jacques Le Roux added a comment - Maybe, I did not question it, another task...
            pierresmits Pierre Smits added a comment -

            hansbak To what are you referring? Neither the patches, nor the link provides show dropdown functionality of agreements.

            When looking at the example provided (https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=10000) and clicking on the dropdown of Invoice Item Type I see a lot of double entries for returns.

            pierresmits Pierre Smits added a comment - hansbak To what are you referring? Neither the patches, nor the link provides show dropdown functionality of agreements. When looking at the example provided ( https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=10000 ) and clicking on the dropdown of Invoice Item Type I see a lot of double entries for returns.

            Backported in
            R12.04 r1533568
            R11.04 r1533569

            jleroux Jacques Le Roux added a comment - Backported in R12.04 r1533568 R11.04 r1533569

            People

              jleroux Jacques Le Roux
              ankit.jain Ankit Jain
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: