Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5074

date-find in form widget does not persist value

    Details

    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      Any search form that calls "performFind" and has a "date-find" tag will not persist but it will give correct search results.

      For example, If I go to Order -> Requests and search using any of the date fields, the result will be correct but the field will be blank upon returning results. This behavior affects only dates.

      I suspect the main offender here is a bug in performFind service or one of the services it calls (prepareFind or executeFind). I believe that the "queryStringMap" does not contain the date-find fields in its returned value. I did not look heavily into the code but I think "fld" types are not persisted in-between requests.

      1. OFBIZ-5074.patch
        3 kB
        Christian Carlow
      2. OFBIZ-12.04-5074.patch
        3 kB
        Taher Alkhateeb

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Taher,

        Your patch is in R12.04 at r1666648

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Taher, Your patch is in R12.04 at r1666648
        Hide
        taher Taher Alkhateeb added a comment -

        Bump, please apply the patch

        Show
        taher Taher Alkhateeb added a comment - Bump, please apply the patch
        Hide
        taher Taher Alkhateeb added a comment -

        Hi Jacques,

        I have modified and tested the patch on release 12.04 and I believe it works correctly. Please apply

        Show
        taher Taher Alkhateeb added a comment - Hi Jacques, I have modified and tested the patch on release 12.04 and I believe it works correctly. Please apply
        Hide
        taher Taher Alkhateeb added a comment -

        patch for ofbiz 12.04

        Show
        taher Taher Alkhateeb added a comment - patch for ofbiz 12.04
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Taher,

        For 12.04 if you do so please attach a patch here and I will commit it, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Taher, For 12.04 if you do so please attach a patch here and I will commit it, thanks!
        Hide
        taher Taher Alkhateeb added a comment -

        Hi Jacques,

        Happy you guys are sweeping through these bug crush sprints. I am excited about tackling a few my self moving forward. Thank you for the commit, I think I can adapt the patch to 12.04 until we upgrade.

        Show
        taher Taher Alkhateeb added a comment - Hi Jacques, Happy you guys are sweeping through these bug crush sprints. I am excited about tackling a few my self moving forward. Thank you for the commit, I think I can adapt the patch to 12.04 until we upgrade.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        BTW thanks Taher for the report and the track!

        Show
        jacques.le.roux Jacques Le Roux added a comment - BTW thanks Taher for the report and the track!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Christian

        Your slightly modified patch is in trunk at r1664696

        It's more an improvement but I still backported to R14.12 at r1664697. Other versions are too conflicting

        I don't close in case you would like to handle the date operator in this same issue...

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Christian Your slightly modified patch is in trunk at r1664696 It's more an improvement but I still backported to R14.12 at r1664697. Other versions are too conflicting I don't close in case you would like to handle the date operator in this same issue...
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        OK that's already a start. It indeed needs to be improved, at least to keep the related date operator... Would you want to do it? Else we can create a new Jira issue...

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited OK that's already a start. It indeed needs to be improved, at least to keep the related date operator... Would you want to do it? Else we can create a new Jira issue...
        Hide
        ofbizzer Christian Carlow added a comment -

        Hey Jacques,

        I said starting point because I'm not sure if it handles default values and other field settings that may need to be applied after my patch.

        I'll check more closely for spaces over tabs for upcoming patches. Thanks.

        Show
        ofbizzer Christian Carlow added a comment - Hey Jacques, I said starting point because I'm not sure if it handles default values and other field settings that may need to be applied after my patch. I'll check more closely for spaces over tabs for upcoming patches. Thanks.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Why only a starting point?

        After formatting your patch (tabs instead of 4 spaces) and using UtilGenerics.checkMap() instead of (Map<String, Object>) that sounds correct and enough for me to commit and close, something else?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Why only a starting point? After formatting your patch (tabs instead of 4 spaces) and using UtilGenerics.checkMap() instead of (Map<String, Object>) that sounds correct and enough for me to commit and close, something else?
        Hide
        ofbizzer Christian Carlow added a comment -

        This is a starting point for this functionality.

        Show
        ofbizzer Christian Carlow added a comment - This is a starting point for this functionality.
        Hide
        ofbizzer Christian Carlow added a comment -

        This issue is still relevant and needed. The <date-find> values are not persisted after submission due to MacroFormRenderer.java not evaluating value and value2 correctly. In face, value2 isn't event passed to the definition in framework/widget/templates/htmlFormMacroLibrary.ftl.

        Show
        ofbizzer Christian Carlow added a comment - This issue is still relevant and needed. The <date-find> values are not persisted after submission due to MacroFormRenderer.java not evaluating value and value2 correctly. In face, value2 isn't event passed to the definition in framework/widget/templates/htmlFormMacroLibrary.ftl.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            taher Taher Alkhateeb
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile