Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5034

Contact us with service message & email notification

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 14.12.01, 13.07.02, 16.11.01
    • Component/s: ecommerce
    • Labels:
      None
    • Environment:

      trunk 1384260

      Description

      Contact us submit doesn't display a message on the page (ex : "Submit OK") and doesn't send an email notification

        Activity

        Hide
        eric13007 Eric de Maulde added a comment -

        This patch modifies disconnected and connected contact us.
        It adds :
        _ Service message displaying on submit
        _ Email notification sending on submit

        Show
        eric13007 Eric de Maulde added a comment - This patch modifies disconnected and connected contact us. It adds : _ Service message displaying on submit _ Email notification sending on submit
        Hide
        eric13007 Eric de Maulde added a comment -

        This patch can't display a service message on submit for a connected user, but there isn't any error !

        Show
        eric13007 Eric de Maulde added a comment - This patch can't display a service message on submit for a connected user, but there isn't any error !
        Hide
        amardeepsj Amardeep Singh Jhajj added a comment - - edited

        Steps to regenerate:
        1. Go to ecommerce store.
        2. Click on contactus link.
        3. Submit Contact us query with your contact details.

        Expected Result: Some sensible feedback message should be displayed to user & an email should be sent to company email address
        Actual result : Default message is shown as 'service executed successfully' & no email is sent to company email address

        Resolution and testing:

        The patch modifies "createAnonContact" event from specialpurpose/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml

        • instead of calling "createCommunicationEventWithoutPermission" service we can call "sendContactUsEmailToCompany" which itself call "createCommunicationEventWithoutPermission" and send email additionally.
        • After service execution we can display a message using new UiLabel "ThankYouForContactingUs".

        Expected Result: A feedback message should be displayed as "Thank you for contacting us" & an email should be delivered to company email address.

        Patch will work for Release 13.07, 14.12 and trunk.

        Show
        amardeepsj Amardeep Singh Jhajj added a comment - - edited Steps to regenerate: 1. Go to ecommerce store. 2. Click on contactus link. 3. Submit Contact us query with your contact details. Expected Result: Some sensible feedback message should be displayed to user & an email should be sent to company email address Actual result : Default message is shown as 'service executed successfully' & no email is sent to company email address Resolution and testing: The patch modifies "createAnonContact" event from specialpurpose/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml instead of calling "createCommunicationEventWithoutPermission" service we can call "sendContactUsEmailToCompany" which itself call "createCommunicationEventWithoutPermission" and send email additionally. After service execution we can display a message using new UiLabel "ThankYouForContactingUs". Expected Result: A feedback message should be displayed as "Thank you for contacting us" & an email should be delivered to company email address. Patch will work for Release 13.07, 14.12 and trunk.
        Hide
        pandeypranay Pranay Pandey added a comment - - edited

        Thanks Eric de Maulde for reporting the issue and Amardeep for providing updated patch.

        Committed to trunk r1652610.
        release13.07 r1652606.
        branch 14.12 r1652604.

        Show
        pandeypranay Pranay Pandey added a comment - - edited Thanks Eric de Maulde for reporting the issue and Amardeep for providing updated patch. Committed to trunk r1652610. release13.07 r1652606. branch 14.12 r1652604.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited
        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Pranay, don't forget to fill the "Fix Version/s" field You can refer to https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA'sissues in case of doubt

          People

          • Assignee:
            pandeypranay Pranay Pandey
            Reporter:
            eric13007 Eric de Maulde
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development