Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-4913

Application Menu items should be link not hidden form.

Details

    Description

      Application menu item should be link not hidden form. As if its hidden form then you can not open it in new tab. Default menu item link type auto, and its create an hidden for for link if controller request call an event, but in menu item this should be link.

      Attachments

        1. OFBIZ-4913.patch
          3 kB
          Deepak Dixit
        2. OFBIZ-4913_new.patch
          2 kB
          Deepak Dixit

        Activity

          deepak Deepak Dixit added a comment -

          Set link type as anchor instead of auto for orderentry, ManagePortalPages, ExampleJackrabbit and selenium menu items.

          deepak Deepak Dixit added a comment - Set link type as anchor instead of auto for orderentry, ManagePortalPages, ExampleJackrabbit and selenium menu items.
          deepak Deepak Dixit added a comment -

          ping...

          deepak Deepak Dixit added a comment - ping...

          Thanks Deepak,

          Your trunked patch is in
          trunk r1499918 (no ExampleJackrabbit, selenium)
          R12.04 r1499920 (no ExampleJackrabbit)

          I will backport later from R12.04 after committing OFBIZ-4794

          jleroux Jacques Le Roux added a comment - Thanks Deepak, Your trunked patch is in trunk r1499918 (no ExampleJackrabbit, selenium) R12.04 r1499920 (no ExampleJackrabbit) I will backport later from R12.04 after committing OFBIZ-4794
          deepak Deepak Dixit added a comment -

          Thanks Jacques.

          –
          Deepak Dixit

          deepak Deepak Dixit added a comment - Thanks Jacques. – Deepak Dixit

          Note: Deepak checked all possible menu items

          jleroux Jacques Le Roux added a comment - Note: Deepak checked all possible menu items
          deepak Deepak Dixit added a comment -

          Jacques,

          Attached patch contains following files:

          • applications/marketing/widget/sfa/SfaMenus.xml
          • applications/order/widget/ordermgr/OrderMenus.xml
          • specialpurpose/example/widget/example/ExampleMenus.xml
          • framework/webtools/widget/Menus.xml
          deepak Deepak Dixit added a comment - Jacques, Attached patch contains following files: applications/marketing/widget/sfa/SfaMenus.xml applications/order/widget/ordermgr/OrderMenus.xml specialpurpose/example/widget/example/ExampleMenus.xml framework/webtools/widget/Menus.xml
          deepak Deepak Dixit added a comment -

          Here is patch for missing menu item.

          deepak Deepak Dixit added a comment - Here is patch for missing menu item.

          Deepak,

          I don't see framework/webtools/widget/Menus.xml in the patch. On the other hand, I tested with trunk demo and did not find issues, did you?

          jleroux Jacques Le Roux added a comment - Deepak, I don't see framework/webtools/widget/Menus.xml in the patch. On the other hand, I tested with trunk demo and did not find issues, did you?
          deepak Deepak Dixit added a comment -

          Actually it was for selenium tests menu, Its removed from trunk
          I added new patch for missing menu items.

          deepak Deepak Dixit added a comment - Actually it was for selenium tests menu, Its removed from trunk I added new patch for missing menu items.

          Deepak,

          Your last patch is in trunk at revision: 1500382

          jleroux Jacques Le Roux added a comment - Deepak, Your last patch is in trunk at revision: 1500382

          Hi Deepack,

          I was wondering if we should close. We will not backport anyway: no bug fixes.

          jleroux Jacques Le Roux added a comment - Hi Deepack, I was wondering if we should close. We will not backport anyway: no bug fixes.

          Mmm, though I backported in R12.04 at r1499920

          jleroux Jacques Le Roux added a comment - Mmm, though I backported in R12.04 at r1499920

          People

            jleroux Jacques Le Roux
            deepak Deepak Dixit
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: