OFBiz
  1. OFBiz
  2. OFBIZ-4810

createPartyContactMech: check for infoString is done without using the contactMechTypeId

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: party
    • Labels:
      None

      Description

      The check for an existing infoString should use the contactMechTypeId.
      I will provide a patch.

        Activity

        Hide
        Michael Brohl added a comment -

        Hi Jacques,

        thanks you for your comment. You are right, the part I commented out is needed for the check.
        Sascha already fixed it.

        Thanks and regards,

        Michael

        Show
        Michael Brohl added a comment - Hi Jacques, thanks you for your comment. You are right, the part I commented out is needed for the check. Sascha already fixed it. Thanks and regards, Michael
        Hide
        Sascha Rodekamp added a comment -

        Hi Michael, hi Jacques

        i committed a modified version of the patch.
        The part Jacques recommended is used by the condition list. The comments where made extendedly, i removed them.

        In Trunk @Rev 1326567

        Have a good day,
        Sascha

        Show
        Sascha Rodekamp added a comment - Hi Michael, hi Jacques i committed a modified version of the patch. The part Jacques recommended is used by the condition list. The comments where made extendedly, i removed them. In Trunk @Rev 1326567 Have a good day, Sascha
        Hide
        Jacques Le Roux added a comment -

        Hi Michael,

        You commented out

                    <entity-one entity-name="ContactMechType" value-field="contactMechType">
                        <field-map field-name="contactMechTypeId" from-field="partyAndContactMech.contactMechTypeId"/>
                    </entity-one>
        

        But you left

        <if-compare operator="equals" value="N" field="contactMechType.hasTable"/>
        

        This is inconsistent. Did you intend to also remove the check upon contactMechType.hasTable (and forgot)? And then why to remove this check?

        BTW I'd use rather if-compare-field, but that's very minor.

        Show
        Jacques Le Roux added a comment - Hi Michael, You commented out <entity-one entity-name= "ContactMechType" value-field= "contactMechType" > <field-map field-name= "contactMechTypeId" from-field= "partyAndContactMech.contactMechTypeId" /> </entity-one> But you left < if -compare operator = "equals" value= "N" field= "contactMechType.hasTable" /> This is inconsistent. Did you intend to also remove the check upon contactMechType.hasTable (and forgot)? And then why to remove this check? BTW I'd use rather if-compare-field, but that's very minor.
        Hide
        Michael Brohl added a comment -

        The patch.

        Show
        Michael Brohl added a comment - The patch.

          People

          • Assignee:
            Sascha Rodekamp
            Reporter:
            Michael Brohl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development