OFBiz
  1. OFBiz
  2. OFBIZ-4777

Add missing ConverterLoader to framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader for running FOBiz in debug under Eclipse

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Trunk
    • Component/s: framework
    • Labels:
      None
    • Environment:

      WXP SP3 JDK 1.6.0_30

      Description

      Hi

      In order to run OFBiz in debug mode under Eclipse with hot class reloading, one needs to add the following Converters to the services framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader because they are added at build time by the build.xml of the framework. Thus, they are missing when running OFBiz as an full Eclipse debug launcher.

      org.ofbiz.base.conversion.BooleanConverters
      org.ofbiz.base.conversion.CollectionConverters
      org.ofbiz.base.conversion.DateTimeConverters
      org.ofbiz.base.conversion.JSONConverters
      org.ofbiz.base.conversion.MiscConverters
      org.ofbiz.base.conversion.NetConverters
      org.ofbiz.base.conversion.NumberConverters

      Rgds

      1. ofbiz-services.patch
        0.7 kB
        Francis ANDRE

        Activity

        Hide
        Jacques Le Roux added a comment -

        Thanks Francis,

        Your patch is in trunk at r1308085

        Show
        Jacques Le Roux added a comment - Thanks Francis, Your patch is in trunk at r1308085
        Hide
        Jacques Le Roux added a comment -

        Francis,

        Please take this commit into account in your explanation in Wiki, thanks!

        Show
        Jacques Le Roux added a comment - Francis, Please take this commit into account in your explanation in Wiki, thanks!
        Hide
        Jacques Le Roux added a comment -

        Thanks Francis

        Show
        Jacques Le Roux added a comment - Thanks Francis
        Hide
        Jacques Le Roux added a comment -

        Hi Francis,

        Is there a reason why you added these lines in framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader rather than creating a framework/base/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader file and put these lines there?

        Show
        Jacques Le Roux added a comment - Hi Francis, Is there a reason why you added these lines in framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader rather than creating a framework/base/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader file and put these lines there?
        Hide
        Francis ANDRE added a comment -

        Hi Jacques

        No, there is no tangible reason for placing the missing converters there framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader more than framework/base/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader. The fix was fiwing the issue of hot class loading and I did not look for a better place.

        Show
        Francis ANDRE added a comment - Hi Jacques No, there is no tangible reason for placing the missing converters there framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader more than framework/base/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader. The fix was fiwing the issue of hot class loading and I did not look for a better place.
        Hide
        Jacques Le Roux added a comment -

        Francis,

        Could you please try for me if moving the missing converters from framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader to framework/base/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader still allows to run OFBiz in debug mode under Eclipse with hot class reloading?

        Thanks!

        Show
        Jacques Le Roux added a comment - Francis, Could you please try for me if moving the missing converters from framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader to framework/base/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader still allows to run OFBiz in debug mode under Eclipse with hot class reloading? Thanks!

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Francis ANDRE
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development