OFBiz
  1. OFBiz
  2. OFBIZ-4660

OrderListState need to be Serializable for clustering

    Details

      Description

      OrderListState is to be set to session, so it needs to be Serializable for clustering.

      I got this error:

      ---- cause ---------------------------------------------------------------------
      Exception: java.lang.IllegalArgumentException
      Message: setAttribute: Non-serializable attribute _ORDER_LIST_STATUS_
      ---- stack trace ---------------------------------------------------------------
      java.lang.IllegalArgumentException: setAttribute: Non-serializable attribute _ORDER_LIST_STATUS_
      org.apache.catalina.session.StandardSession.setAttribute(StandardSession.java:1456)
      org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:658)
      org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:642)
      org.apache.catalina.session.StandardSessionFacade.setAttribute(StandardSessionFacade.java:156)
      org.ofbiz.order.order.OrderListState.getInstance(OrderListState.java:137)
      sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      java.lang.reflect.Method.invoke(Method.java:597)
      org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:88)
      org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrapNoCoerce.invoke(StaticMetaMethodSite.java:148)
      org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.call(StaticMetaMethodSite.java:88)
      org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:124)
      OrderList.run(OrderList.groovy:29)

      Regards,
      Chatree Srichart

      1. order_list_state.patch
        0.8 kB
        Chatree Srichart
      2. order_list_state.patch
        0.9 kB
        Chatree Srichart

        Activity

        Hide
        Jacques Le Roux added a comment -

        Thanks Chatree,

        Your patch is in
        trunk r1294090
        R11.04 r1294092
        R10.04 r1294093
        R09.04 r1294095 (done by hand)

        I don't see any problem committing this patch. But beware the design of OrderListState is faulty regarding notably browsers tabs, see bottom of OFBIZ-644

        Show
        Jacques Le Roux added a comment - Thanks Chatree, Your patch is in trunk r1294090 R11.04 r1294092 R10.04 r1294093 R09.04 r1294095 (done by hand) I don't see any problem committing this patch. But beware the design of OrderListState is faulty regarding notably browsers tabs, see bottom of OFBIZ-644
        Hide
        Chatree Srichart added a comment -

        Thanks Jacques Le Roux. I created a new patch for that.

        Regards,
        Chatree Srichart

        Show
        Chatree Srichart added a comment - Thanks Jacques Le Roux. I created a new patch for that. Regards, Chatree Srichart
        Hide
        Jacques Le Roux added a comment -

        Hi Chatree,

        I'd not use
        + private static final long serialVersionUID = 1L;
        but
        + @SuppressWarnings("serial")
        rather

        This is what we decided some times ago http://markmail.org/message/x7r34bss3fwy2bn3

        Show
        Jacques Le Roux added a comment - Hi Chatree, I'd not use + private static final long serialVersionUID = 1L; but + @SuppressWarnings("serial") rather This is what we decided some times ago http://markmail.org/message/x7r34bss3fwy2bn3
        Hide
        Chatree Srichart added a comment -

        I hope the patch, order_list_state.patch attached file, will solve this problem.

        Show
        Chatree Srichart added a comment - I hope the patch, order_list_state.patch attached file, will solve this problem.

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Chatree Srichart
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development