OFBiz
  1. OFBiz
  2. OFBIZ-4468

After login it shows error 'Product not found!'

    Details

      Description

      If you are browsing a product. And then hit login. After login, you will see error 'Product not found!'
      e.g: while browsing following product, if you click login
      http://demo-trunk.ofbiz.apache.org:8080/ecommerce/tiny-chrome-widget-WG-5569-p

      after successful login, you will be redirected to:
      https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/checkLogin/product

      1. OFBIZ-4468
        1 kB
        Akash Jain

        Activity

        Hide
        Bhargav Trivedi added a comment -
        Show
        Bhargav Trivedi added a comment - I found the same issue in the latest trunk as well. http://ofbiz.135035.n4.nabble.com/Product-not-found-for-Product-ID-td4633348.html
        Hide
        Deepak Agarwal added a comment -

        It could be a side effect of following:

        createShoppingListItem logically doesn't require a login but it then checks for checkShoppingListItemSecurity and here it falls out because of the security.

        I see 2 problem :

        1) createShoppingListitem if can be accessed without login then it should not check for security later on.
        2) While adding a new item to shopping cart, setQuantity method of ShoppingCartItem calls ShoppingListEvents.fillAutoSaveList(cart, dispatcher); IMHO it should only be called if user is logged in.

        Show
        Deepak Agarwal added a comment - It could be a side effect of following: createShoppingListItem logically doesn't require a login but it then checks for checkShoppingListItemSecurity and here it falls out because of the security. I see 2 problem : 1) createShoppingListitem if can be accessed without login then it should not check for security later on. 2) While adding a new item to shopping cart, setQuantity method of ShoppingCartItem calls ShoppingListEvents.fillAutoSaveList(cart, dispatcher); IMHO it should only be called if user is logged in.
        Hide
        Jacques Le Roux added a comment -

        I think this has been fixed recently, could you please check?

        Show
        Jacques Le Roux added a comment - I think this has been fixed recently, could you please check?
        Hide
        Deepak Dixit added a comment -

        This issue still exists.

        Show
        Deepak Dixit added a comment - This issue still exists.
        Hide
        Jacques Le Roux added a comment -

        Thanks for report Deepak

        Show
        Jacques Le Roux added a comment - Thanks for report Deepak
        Hide
        Akash Jain added a comment -

        Regenerated this issue over trunk and 13.07 branch. This issue also exists for category page.

        Show
        Akash Jain added a comment - Regenerated this issue over trunk and 13.07 branch. This issue also exists for category page.
        Hide
        Akash Jain added a comment -

        Attached patch for the same.

        Show
        Akash Jain added a comment - Attached patch for the same.
        Hide
        Ashish Vijaywargiya added a comment -

        Thanks Kiran for reporting the issue. Thanks Akash for the contribution.

        Committed at:

        trunk - 1639873
        13.07 - 1639875

        Show
        Ashish Vijaywargiya added a comment - Thanks Kiran for reporting the issue. Thanks Akash for the contribution. Committed at: trunk - 1639873 13.07 - 1639875
        Hide
        Jacques Le Roux added a comment -

        R12.04 r1639911

        Show
        Jacques Le Roux added a comment - R12.04 r1639911

          People

          • Assignee:
            Ashish Vijaywargiya
            Reporter:
            Kiran Gawde
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development