OFBiz
  1. OFBiz
  2. OFBIZ-4332

Pagination in find order screen doesn't work (With patch)

    Details

      Description

      On find order screen when there is more than 20 orders to display the pagination doesn't work: when the next button is pressed no orders are displayed.

      Patch attached

        Activity

        Hide
        Ankit Jain added a comment -

        This is working fine as checked on 12.04 locally and on demo trunk
        https://demo-trunk.ofbiz.apache.org/ordermgr/control/searchorders

        Jacques, can we close this issue as its not reproducible?

        Thanks.

        Show
        Ankit Jain added a comment - This is working fine as checked on 12.04 locally and on demo trunk https://demo-trunk.ofbiz.apache.org/ordermgr/control/searchorders Jacques, can we close this issue as its not reproducible? Thanks.
        Hide
        Jacques Le Roux added a comment -

        Hi Ankit,

        I agree it works for trunk. I did not try R12.04, I guess it's also ok.

        To try, since this screen does not take into account the widget.form.defaultViewSize properties, I used the GET parameter searchorders?viewSize=2 which is anyway no longer allowed for security reasons. I will commit a change for that.

        I noticed though that Stéphane was right for R11.04 (https://demo-stable.ofbiz.apache.org/ordermgr/control/searchorders?viewSize=2 does not work) and R10.04 (https://demo-old.ofbiz.apache.org/ordermgr/control/searchorders?viewSize=2). I did not take the time to look at this issue tonight, I will see later...

        Thanks for your help!

        Show
        Jacques Le Roux added a comment - Hi Ankit, I agree it works for trunk. I did not try R12.04, I guess it's also ok. To try, since this screen does not take into account the widget.form.defaultViewSize properties, I used the GET parameter searchorders?viewSize=2 which is anyway no longer allowed for security reasons. I will commit a change for that. I noticed though that Stéphane was right for R11.04 ( https://demo-stable.ofbiz.apache.org/ordermgr/control/searchorders?viewSize=2 does not work) and R10.04 ( https://demo-old.ofbiz.apache.org/ordermgr/control/searchorders?viewSize=2 ). I did not take the time to look at this issue tonight, I will see later... Thanks for your help!
        Hide
        Jacques Le Roux added a comment -

        Hi Ankit,

        Huho, I now reproduce on trunk, weird! OK I will get back to this later...

        Show
        Jacques Le Roux added a comment - Hi Ankit, Huho, I now reproduce on trunk, weird! OK I will get back to this later...
        Hide
        Jacques Le Roux added a comment -

        Ha, no I clicked on the link above

        Show
        Jacques Le Roux added a comment - Ha, no I clicked on the link above
        Hide
        Jacques Le Roux added a comment -

        Thanks Stéphane, and Ankit for testing,

        Stéphane, your patch is in
        R11.04 r1487324
        R10.04 r1487358

        There is maybe a better fix, but, since there are no issues in trunk and R12.04, I decided to apply this patch in R11.04 and R10.04.

        Show
        Jacques Le Roux added a comment - Thanks Stéphane, and Ankit for testing, Stéphane, your patch is in R11.04 r1487324 R10.04 r1487358 There is maybe a better fix, but, since there are no issues in trunk and R12.04, I decided to apply this patch in R11.04 and R10.04.
        Hide
        Ankit Jain added a comment -

        Thanks Jacques.

        Show
        Ankit Jain added a comment - Thanks Jacques.

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Stéphane DUCAS
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development