[OFBIZ-4026] Shopping Cart Item issue with BigDecimal

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: jQuery, Release Branch 09.04, Release 09.04, Release Branch 10.04, Trunk
• Fix Version/s: Release Branch 09.04, Release Branch 10.04, Trunk
• Component/s: order

Environment

All

• Assignee: Jacques Le Roux
• Reporter: Patrick Antivackis
• Created: 18/Nov/10 08:17
• Updated: 04/Dec/10 14:30
• Resolved: 04/Dec/10 14:30

Description

In applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java
the setQuantity method should use this.quantity.compareTo(quantity) == 0 instead of this.quantity==quantity like depicted below

   protected void setQuantity(BigDecimal quantity, LocalDispatcher dispatcher, ShoppingCart cart, boolean triggerExternalOps, boolean resetShipGroup, boolean updateProductPrice, boolean skipInventoryChecks) throws CartItemModifyException {
       if (this.quantity == quantity)

{            return;        }

The issue is really visible when the cart is fully loaded (lot of products) as the return will never occur and the store is configurerd in an autosavecart mode.

For example a cart with 48 products will take very long time to process for each additem or modifycart event.