OFBiz
  1. OFBiz
  2. OFBIZ-3889

When editing Portal Pages, Drag & Drop for Portlets does not work

    Details

      Description

      When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work.
      Where are several Issues in the MyPortal, some have fixes, none is commited to trunk.

      Problems:

      • in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly
      • in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included
      1. fixPortalDnD.diff
        4 kB
        Karl Pitrich
      2. OFBIZ-3889_fixPortalDnD.trunk-985143.patch
        6 kB
        Karl Pitrich
      3. OFBIZ-3889 fixPortalDnD.patch
        4 kB
        Jacques Le Roux

        Activity

        Jacques Le Roux made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Fix Version/s Release Branch 10.04 [ 12314832 ]
        Fix Version/s SVN trunk [ 12311928 ]
        Resolution Fixed [ 1 ]
        Hide
        Jacques Le Roux added a comment -

        Thanks Karl,

        While working on this I have found other issues: the login.ftl files used in hhfacility and myportal were not tenant enabled. They are different but by chance in myportal very close to common so I was finally able to do both along with your changes at r985163 in trunk and r985166 in R10.04

        Actually I wanted to do 2 commits but forget to uncheck the files while doing a second attempt to commit. I have updated the commit log.

        Show
        Jacques Le Roux added a comment - Thanks Karl, While working on this I have found other issues: the login.ftl files used in hhfacility and myportal were not tenant enabled. They are different but by chance in myportal very close to common so I was finally able to do both along with your changes at r985163 in trunk and r985166 in R10.04 Actually I wanted to do 2 commits but forget to uncheck the files while doing a second attempt to commit. I have updated the commit log.
        Karl Pitrich made changes -
        Hide
        Karl Pitrich added a comment -

        Attached new patch against trunk 985143. Tested with Chrome, Safari and Firefox.

        Show
        Karl Pitrich added a comment - Attached new patch against trunk 985143. Tested with Chrome, Safari and Firefox.
        Hide
        Karl Pitrich added a comment - - edited

        Please hang on, I will checkout the current trunk again, apply my changes and create a new patch.

        Show
        Karl Pitrich added a comment - - edited Please hang on, I will checkout the current trunk again, apply my changes and create a new patch.
        Jacques Le Roux made changes -
        Attachment OFBIZ-3889 fixPortalDnD.patch [ 12452007 ]
        Hide
        Jacques Le Roux added a comment -

        Hi Karl,

        Could you please give me more details? Because I see it does not work on trunk demo (though moving portlets with buttons works) but it does not work either when you change are applied. Could I miss something? BTW I have created a proper patch from your changes, maybe something did not get through?

        Show
        Jacques Le Roux added a comment - Hi Karl, Could you please give me more details? Because I see it does not work on trunk demo (though moving portlets with buttons works) but it does not work either when you change are applied. Could I miss something? BTW I have created a proper patch from your changes, maybe something did not get through?
        Hide
        Jacques Le Roux added a comment -

        You are welcome Karl

        Show
        Jacques Le Roux added a comment - You are welcome Karl
        Hide
        Karl Pitrich added a comment -

        I promise to read the doc prior my next patch thank you.

        Show
        Karl Pitrich added a comment - I promise to read the doc prior my next patch thank you.
        Hide
        Jacques Le Roux added a comment -

        BTW Karl,

        Could you please use rather a patch format than a diff, it's easier for us to simply apply from Eclipse. More at Contributors Best Practices

        Thanks

        Show
        Jacques Le Roux added a comment - BTW Karl, Could you please use rather a patch format than a diff, it's easier for us to simply apply from Eclipse. More at Contributors Best Practices Thanks
        Hide
        Jacques Le Roux added a comment -

        OK,

        I tried only inside Eclipse, from Tortoise it works well... Will see that later...

        Show
        Jacques Le Roux added a comment - OK, I tried only inside Eclipse, from Tortoise it works well... Will see that later...
        Hide
        Karl Pitrich added a comment -

        Hi,

        strange. I'm certain diff'ed against the current trunk, gut co'd it ... sorry.

        the only change in PortalAdmScreens.xml are the addition of these tho lines marked with +:
        <set field="headerItem" value="PortalPageAdminItem"/>
        + <set field="layoutSettings.javaScripts[]" value="/images/myportal.js" global="true"/>
        + <set field="layoutSettings.styleSheets[+0]" value="/images/myportal.css" global="true"/>

        • Karl

        _____________________________________________

        Lusini GmbH
        Adams-Lehmann-Straße 109, 80797 München
        Mobil +49 171 4970703
        E-Mail karl.pitrich@lusini.com
        _____________________________________________

        Show
        Karl Pitrich added a comment - Hi, strange. I'm certain diff'ed against the current trunk, gut co'd it ... sorry. the only change in PortalAdmScreens.xml are the addition of these tho lines marked with +: <set field="headerItem" value="PortalPageAdminItem"/> + <set field="layoutSettings.javaScripts[]" value="/images/myportal.js" global="true"/> + <set field="layoutSettings.styleSheets [+0] " value="/images/myportal.css" global="true"/> Karl _____________________________________________ Lusini GmbH Adams-Lehmann-Straße 109, 80797 München Mobil +49 171 4970703 E-Mail karl.pitrich@lusini.com _____________________________________________
        Hide
        Jacques Le Roux added a comment -

        Hi Karl,

        Looks like this patch is not working on trunk. There are certainly others reasons as I removed all "ofbiz-official/" and "dev/hg/ofbiz/" in the file but still get conflict in PortalAdmScreens.xml. I guess it has been done on R10.04 and not trunk?

        Show
        Jacques Le Roux added a comment - Hi Karl, Looks like this patch is not working on trunk. There are certainly others reasons as I removed all "ofbiz-official/" and "dev/hg/ofbiz/" in the file but still get conflict in PortalAdmScreens.xml. I guess it has been done on R10.04 and not trunk?
        Jacques Le Roux made changes -
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Karl Pitrich made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Karl Pitrich made changes -
        Field Original Value New Value
        Attachment fixPortalDnD.diff [ 12451791 ]
        Hide
        Karl Pitrich added a comment -

        Fix for described Issues.

        Show
        Karl Pitrich added a comment - Fix for described Issues.
        Karl Pitrich created issue -

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Karl Pitrich
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development