OFBiz
  1. OFBiz
  2. OFBIZ-3868

Adding de UI Lables on framework CommonUILabels

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: framework
    • Labels:
      None
    • Environment:

      irrelevant; XML config data

      Description

      All missing de UI labels have been added in the CommonUiLables.xml file.

      Note: This patch also includes the UI Labels required for JIRA issue OFBIZ-3844 (i.e. replacing the OFBIZ-3844_Splitting CommonRate and CommonProductRating_part2.patch which has now been removed from OFBIY-3844.

        Issue Links

          Activity

          Hide
          Jacques Le Roux added a comment -

          Thanks Markus,

          Your slightly modified patch is in trunk at r1293232

          Show
          Jacques Le Roux added a comment - Thanks Markus, Your slightly modified patch is in trunk at r1293232
          Hide
          Jacques Le Roux added a comment -

          Good work Markus (but the patch format ;o)

          This (new attached) patch applies but I'd like to have a review by another German speaking committer or contributor, because some labels are replaced and my German is not good enough (it's not good at all) to be able to take a decision by myslef

          Here are the points I'm unsure about

          -        <value xml:lang="de">Forderungen</value>
          +        <value xml:lang="de">Debitoren</value>
          
          -        <value xml:lang="de">Klicken Sie hier</value>
          +        <value xml:lang="de">Hier klicken</value>
          
          -        <value xml:lang="de">Ansehen</value>
          +        <value xml:lang="de">Suchen</value>
          
          -        <value xml:lang="de">Neues Passwort (zur Überprüfung)</value>
          +        <value xml:lang="de">Neues Passwort (Wiederholung)</value>
          
          -        <value xml:lang="de">Erstellt von Benutzeranmeldung</value>
          +        <value xml:lang="de">Erstellt von Benutzer</value>
          
          -        <value xml:lang="de">Zuletzt geändert von Benutzeranmeldung</value>
          +        <value xml:lang="de">Zuletzt geändert von Benutzer</value>
          

          If nobody answer, in few days I will apply as is...

          Show
          Jacques Le Roux added a comment - Good work Markus (but the patch format ;o) This (new attached) patch applies but I'd like to have a review by another German speaking committer or contributor, because some labels are replaced and my German is not good enough (it's not good at all) to be able to take a decision by myslef Here are the points I'm unsure about - <value xml:lang= "de" >Forderungen</value> + <value xml:lang= "de" >Debitoren</value> - <value xml:lang= "de" >Klicken Sie hier</value> + <value xml:lang= "de" >Hier klicken</value> - <value xml:lang= "de" >Ansehen</value> + <value xml:lang= "de" >Suchen</value> - <value xml:lang= "de" >Neues Passwort (zur Überprüfung)</value> + <value xml:lang= "de" >Neues Passwort (Wiederholung)</value> - <value xml:lang= "de" >Erstellt von Benutzeranmeldung</value> + <value xml:lang= "de" >Erstellt von Benutzer</value> - <value xml:lang= "de" >Zuletzt geändert von Benutzeranmeldung</value> + <value xml:lang= "de" >Zuletzt geändert von Benutzer</value> If nobody answer, in few days I will apply as is...
          Hide
          Markus M. May added a comment -

          Added a new patch which should be working

          Show
          Markus M. May added a comment - Added a new patch which should be working
          Hide
          Jacques Le Roux added a comment -

          Ping

          Show
          Jacques Le Roux added a comment - Ping
          Hide
          Marco Risaliti added a comment -

          Improvements on labels goes only on trunk

          Show
          Marco Risaliti added a comment - Improvements on labels goes only on trunk
          Hide
          Jacques Le Roux added a comment -

          Carsten,

          Still some errors in your patch:

          patching file framework/common/config/CommonUiLabels.xml
          Hunk #1 FAILED at 20.
          Hunk #2 succeeded at 542 with fuzz 1 (offset 12 lines).
          Hunk #3 succeeded at 1030 with fuzz 1 (offset 48 lines).
          Hunk #4 succeeded at 1204 with fuzz 1 (offset 61 lines).
          Hunk #5 FAILED at 1213.
          Hunk #6 succeeded at 1231 with fuzz 1 (offset 64 lines).
          Hunk #7 succeeded at 1271 with fuzz 1 (offset 69 lines).
          Hunk #8 succeeded at 1281 with fuzz 1 (offset 71 lines).
          Hunk #9 succeeded at 1374 with fuzz 1 (offset 79 lines).
          Hunk #10 succeeded at 1805 with fuzz 1 (offset 129 lines).
          Hunk #11 succeeded at 1882 with fuzz 2 (offset 139 lines).
          Hunk #12 succeeded at 2013 with fuzz 1 (offset 154 lines).
          Hunk #13 succeeded at 2083 with fuzz 1 (offset 161 lines).
          Hunk #14 succeeded at 2107 with fuzz 2 (offset 164 lines).
          Hunk #15 FAILED at 2236.
          Hunk #16 succeeded at 2345 with fuzz 2 (offset 182 lines).
          Hunk #17 succeeded at 2559 with fuzz 2 (offset 202 lines).
          Hunk #18 FAILED at 2717.
          Hunk #19 FAILED at 2733.
          Hunk #20 FAILED at 2775.
          Hunk #21 FAILED at 2970.
          Hunk #22 FAILED at 3138.
          Hunk #23 succeeded at 3346 with fuzz 2 (offset 281 lines).
          Hunk #24 succeeded at 3461 with fuzz 1 (offset 295 lines).
          Hunk #25 succeeded at 3648 with fuzz 1 (offset 320 lines).
          Hunk #26 FAILED at 3722.
          Hunk #27 FAILED at 3785.
          Hunk #28 FAILED at 3806.
          Hunk #29 succeeded at 3870 with fuzz 1 (offset 353 lines).
          Hunk #30 succeeded at 3910 with fuzz 2 (offset 358 lines).
          Hunk #31 succeeded at 4040 with fuzz 1 (offset 372 lines).
          Hunk #32 succeeded at 4146 with fuzz 1 (offset 389 lines).
          Hunk #33 FAILED at 4248.
          Hunk #34 FAILED at 4393.
          Hunk #35 succeeded at 4505 with fuzz 2 (offset 429 lines).
          Hunk #36 FAILED at 4589.
          Hunk #37 succeeded at 4709 with fuzz 1 (offset 474 lines).
          Hunk #38 FAILED at 5059.
          Hunk #39 succeeded at 5173 with fuzz 1 (offset 514 lines).
          Hunk #40 succeeded at 5266 with fuzz 1 (offset 523 lines).
          Hunk #41 FAILED at 5356.
          Hunk #42 succeeded at 5429 with fuzz 2 (offset 546 lines).
          Hunk #43 FAILED at 5734.
          Hunk #44 FAILED at 5749.
          Hunk #45 succeeded at 5789 with fuzz 2 (offset 573 lines).
          Hunk #46 FAILED at 5923.
          Hunk #47 succeeded at 6000 with fuzz 1 (offset 603 lines).
          Hunk #48 succeeded at 6124 with fuzz 2 (offset 616 lines).
          Hunk #49 FAILED at 6330.
          Hunk #50 succeeded at 6370 with fuzz 2 (offset 641 lines).
          Hunk #51 succeeded at 6381 with fuzz 2 (offset 642 lines).
          Hunk #52 succeeded at 6392 with fuzz 1 (offset 643 lines).
          Hunk #53 succeeded at 6403 with fuzz 2 (offset 644 lines).
          Hunk #54 succeeded at 6414 with fuzz 2 (offset 645 lines).
          Hunk #55 succeeded at 6490 with fuzz 2 (offset 650 lines).
          Hunk #56 FAILED at 6673.
          Hunk #57 FAILED at 6701.
          Hunk #58 succeeded at 7018 with fuzz 1 (offset 694 lines).
          Hunk #59 FAILED at 7168.
          Hunk #60 succeeded at 7196 with fuzz 1 (offset 708 lines).
          Hunk #61 succeeded at 8070 with fuzz 2 (offset 782 lines).
          Hunk #62 FAILED at 8106.
          Hunk #63 succeeded at 8300 with fuzz 1 (offset 816 lines).
          Hunk #64 FAILED at 8746.
          Hunk #65 succeeded at 8797 with fuzz 2 (offset 855 lines).
          Hunk #66 succeeded at 8819 with fuzz 2 (offset 858 lines).
          Hunk #67 succeeded at 8842 with fuzz 2 (offset 861 lines).
          Hunk #68 FAILED at 8944.
          Hunk #69 succeeded at 8979 with fuzz 2 (offset 871 lines).
          Hunk #70 succeeded at 8989 with fuzz 2 (offset 873 lines).
          Hunk #71 FAILED at 9002.
          Hunk #72 FAILED at 9042.
          Hunk #73 succeeded at 9071 with fuzz 1 (offset 883 lines).
          Hunk #74 succeeded at 9103 with fuzz 1 (offset 889 lines).
          Hunk #75 FAILED at 9151.
          Hunk #76 succeeded at 9170 with fuzz 1 (offset 895 lines).
          Hunk #77 succeeded at 9246 (offset 902 lines).
          Hunk #78 succeeded at 9274 with fuzz 1 (offset 907 lines).
          Hunk #79 FAILED at 9310.
          Hunk #80 FAILED at 9374.
          Hunk #81 succeeded at 9493 with fuzz 2 (offset 929 lines).
          Hunk #82 FAILED at 9514.
          Hunk #83 succeeded at 9552 with fuzz 1 (offset 941 lines).
          Hunk #84 succeeded at 9564 with fuzz 1 (offset 941 lines).
          Hunk #85 FAILED at 9635.
          Hunk #86 succeeded at 9695 with fuzz 2 (offset 978 lines).
          Hunk #87 succeeded at 9782 with fuzz 2 (offset 990 lines).
          33 out of 87 hunks FAILED – saving rejects to file framework/common/config/CommonUiLabels.xml.rej

          Did you update?

          Show
          Jacques Le Roux added a comment - Carsten, Still some errors in your patch: patching file framework/common/config/CommonUiLabels.xml Hunk #1 FAILED at 20. Hunk #2 succeeded at 542 with fuzz 1 (offset 12 lines). Hunk #3 succeeded at 1030 with fuzz 1 (offset 48 lines). Hunk #4 succeeded at 1204 with fuzz 1 (offset 61 lines). Hunk #5 FAILED at 1213. Hunk #6 succeeded at 1231 with fuzz 1 (offset 64 lines). Hunk #7 succeeded at 1271 with fuzz 1 (offset 69 lines). Hunk #8 succeeded at 1281 with fuzz 1 (offset 71 lines). Hunk #9 succeeded at 1374 with fuzz 1 (offset 79 lines). Hunk #10 succeeded at 1805 with fuzz 1 (offset 129 lines). Hunk #11 succeeded at 1882 with fuzz 2 (offset 139 lines). Hunk #12 succeeded at 2013 with fuzz 1 (offset 154 lines). Hunk #13 succeeded at 2083 with fuzz 1 (offset 161 lines). Hunk #14 succeeded at 2107 with fuzz 2 (offset 164 lines). Hunk #15 FAILED at 2236. Hunk #16 succeeded at 2345 with fuzz 2 (offset 182 lines). Hunk #17 succeeded at 2559 with fuzz 2 (offset 202 lines). Hunk #18 FAILED at 2717. Hunk #19 FAILED at 2733. Hunk #20 FAILED at 2775. Hunk #21 FAILED at 2970. Hunk #22 FAILED at 3138. Hunk #23 succeeded at 3346 with fuzz 2 (offset 281 lines). Hunk #24 succeeded at 3461 with fuzz 1 (offset 295 lines). Hunk #25 succeeded at 3648 with fuzz 1 (offset 320 lines). Hunk #26 FAILED at 3722. Hunk #27 FAILED at 3785. Hunk #28 FAILED at 3806. Hunk #29 succeeded at 3870 with fuzz 1 (offset 353 lines). Hunk #30 succeeded at 3910 with fuzz 2 (offset 358 lines). Hunk #31 succeeded at 4040 with fuzz 1 (offset 372 lines). Hunk #32 succeeded at 4146 with fuzz 1 (offset 389 lines). Hunk #33 FAILED at 4248. Hunk #34 FAILED at 4393. Hunk #35 succeeded at 4505 with fuzz 2 (offset 429 lines). Hunk #36 FAILED at 4589. Hunk #37 succeeded at 4709 with fuzz 1 (offset 474 lines). Hunk #38 FAILED at 5059. Hunk #39 succeeded at 5173 with fuzz 1 (offset 514 lines). Hunk #40 succeeded at 5266 with fuzz 1 (offset 523 lines). Hunk #41 FAILED at 5356. Hunk #42 succeeded at 5429 with fuzz 2 (offset 546 lines). Hunk #43 FAILED at 5734. Hunk #44 FAILED at 5749. Hunk #45 succeeded at 5789 with fuzz 2 (offset 573 lines). Hunk #46 FAILED at 5923. Hunk #47 succeeded at 6000 with fuzz 1 (offset 603 lines). Hunk #48 succeeded at 6124 with fuzz 2 (offset 616 lines). Hunk #49 FAILED at 6330. Hunk #50 succeeded at 6370 with fuzz 2 (offset 641 lines). Hunk #51 succeeded at 6381 with fuzz 2 (offset 642 lines). Hunk #52 succeeded at 6392 with fuzz 1 (offset 643 lines). Hunk #53 succeeded at 6403 with fuzz 2 (offset 644 lines). Hunk #54 succeeded at 6414 with fuzz 2 (offset 645 lines). Hunk #55 succeeded at 6490 with fuzz 2 (offset 650 lines). Hunk #56 FAILED at 6673. Hunk #57 FAILED at 6701. Hunk #58 succeeded at 7018 with fuzz 1 (offset 694 lines). Hunk #59 FAILED at 7168. Hunk #60 succeeded at 7196 with fuzz 1 (offset 708 lines). Hunk #61 succeeded at 8070 with fuzz 2 (offset 782 lines). Hunk #62 FAILED at 8106. Hunk #63 succeeded at 8300 with fuzz 1 (offset 816 lines). Hunk #64 FAILED at 8746. Hunk #65 succeeded at 8797 with fuzz 2 (offset 855 lines). Hunk #66 succeeded at 8819 with fuzz 2 (offset 858 lines). Hunk #67 succeeded at 8842 with fuzz 2 (offset 861 lines). Hunk #68 FAILED at 8944. Hunk #69 succeeded at 8979 with fuzz 2 (offset 871 lines). Hunk #70 succeeded at 8989 with fuzz 2 (offset 873 lines). Hunk #71 FAILED at 9002. Hunk #72 FAILED at 9042. Hunk #73 succeeded at 9071 with fuzz 1 (offset 883 lines). Hunk #74 succeeded at 9103 with fuzz 1 (offset 889 lines). Hunk #75 FAILED at 9151. Hunk #76 succeeded at 9170 with fuzz 1 (offset 895 lines). Hunk #77 succeeded at 9246 (offset 902 lines). Hunk #78 succeeded at 9274 with fuzz 1 (offset 907 lines). Hunk #79 FAILED at 9310. Hunk #80 FAILED at 9374. Hunk #81 succeeded at 9493 with fuzz 2 (offset 929 lines). Hunk #82 FAILED at 9514. Hunk #83 succeeded at 9552 with fuzz 1 (offset 941 lines). Hunk #84 succeeded at 9564 with fuzz 1 (offset 941 lines). Hunk #85 FAILED at 9635. Hunk #86 succeeded at 9695 with fuzz 2 (offset 978 lines). Hunk #87 succeeded at 9782 with fuzz 2 (offset 990 lines). 33 out of 87 hunks FAILED – saving rejects to file framework/common/config/CommonUiLabels.xml.rej Did you update?
          Hide
          Carsten Schinzer added a comment -

          created from root now (apologies).

          Show
          Carsten Schinzer added a comment - created from root now (apologies).
          Hide
          Jacques Le Roux added a comment -

          Sorry Carsten,

          I got issues while willing to apply your patch

          1. should be created from root
          2. be sure to use ans updated version when you create the patch (maybe not an issue)
          Show
          Jacques Le Roux added a comment - Sorry Carsten, I got issues while willing to apply your patch should be created from root be sure to use ans updated version when you create the patch (maybe not an issue)
          Hide
          Carsten Schinzer added a comment -

          patch for CommonUiLabels.xml

          Show
          Carsten Schinzer added a comment - patch for CommonUiLabels.xml

            People

            • Assignee:
              Jacques Le Roux
              Reporter:
              Carsten Schinzer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development