Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-382

Implement Party lookup by External Id

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 16.11.01
    • Component/s: party
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      It would be helpful for anyone whom is integrating ofBiz with an external application to be able to expose the externalId property in the Party entity.

      The tasks to complete include:

      • Update the findparty.ftl to include the prompt/form input field for the external id
      • Update the PartyServices.findParty() method to include the logic to handle the externalId argument
      • Add new method getPartyFromExternalId to PartyServices
      • Add getPartyFromExternalId service definition in Party servicedef/services_view.xml
      • Add misc local strings to UI label resource file

      Need to determine if the External Id: input form field should be configuarable so that it only appears if feature is enabled.

      1. OFBIZ-382_new.patch
        8 kB
        Renuka Srishti
      2. OFBIZ-382.patch
        5 kB
        Renuka Srishti

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        That's an interesting point of view Nicolas, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - That's an interesting point of view Nicolas, thanks!
        Hide
        soledad Nicolas Malin added a comment -

        Hello, I don't understand the interest to use an externalId on party while we have a partyIdentification entity.

        I think it would be better to use PartyIdentification like GoodIdentification from Product to extend the search on external ofbiz id.

        [my life] I never realize a project without 3 or 4 different external party identification[/my life] so when I see this issue, it's a little bit light on comparison with the existing

        Show
        soledad Nicolas Malin added a comment - Hello, I don't understand the interest to use an externalId on party while we have a partyIdentification entity. I think it would be better to use PartyIdentification like GoodIdentification from Product to extend the search on external ofbiz id. [my life] I never realize a project without 3 or 4 different external party identification [/my life] so when I see this issue, it's a little bit light on comparison with the existing
        Hide
        deepak.dixit Deepak Dixit added a comment -

        This has been done at r#1747398

        Thanks John Martin for reporting the issue and Renuka for providing the patch.

        Show
        deepak.dixit Deepak Dixit added a comment - This has been done at r#1747398 Thanks John Martin for reporting the issue and Renuka for providing the patch.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Hi Renuka,

        You can upload patch with same name, jira internally handle it

        Show
        deepak.dixit Deepak Dixit added a comment - Hi Renuka, You can upload patch with same name, jira internally handle it
        Hide
        Renuka_Srishti Renuka Srishti added a comment -

        Here is updated patch for the same which covers following points :
        #1. Add field externalId in PartyForms.xml.
        #2. Update the PartyServices.performFindParty() method to include the logic to handle the externalId argument.
        #3. Add new method getPartyFromExternalId to PartyServices.
        #4. Add getPartyFromExternalId service definition in Party servicedef/services_view.xml

        Show
        Renuka_Srishti Renuka Srishti added a comment - Here is updated patch for the same which covers following points : #1. Add field externalId in PartyForms.xml. #2. Update the PartyServices.performFindParty() method to include the logic to handle the externalId argument. #3. Add new method getPartyFromExternalId to PartyServices. #4. Add getPartyFromExternalId service definition in Party servicedef/services_view.xml
        Hide
        Renuka_Srishti Renuka Srishti added a comment -

        Here is the patch for this feature.

        Show
        Renuka_Srishti Renuka Srishti added a comment - Here is the patch for this feature.

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            pbwebguy John Martin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile