[OFBIZ-3010] Bug in createInvoiceForOrderAllItems service definition

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Release Branch 09.04
• Fix Version/s: Release Branch 4.0, Release Branch 09.04
• Component/s: accounting

Environment

Tested on version : ofbiz-rel9.04-2009-09-25-v818777

• Assignee: Bilgin Ismet Ibryam
• Reporter: Cimballi
• Created: 07/Oct/09 23:26
• Updated: 29/Oct/09 01:21
• Resolved: 29/Oct/09 01:21

Description

There is a bug in the definition of the "createInvoiceForOrderAllItems" service .
Here is the current definition :
<service name="createInvoiceForOrderAllItems" engine="java"
location="org.ofbiz.accounting.invoice.InvoiceServices" invoke="createInvoiceForOrderAllItems">
<description>
Create an invoice from existing order using all order items
orderId = The orderId to associate the invoice with
</description>
<attribute name="orderId" type="String" mode="IN" optional="false"/>
<attribute name="invoiceId" type="String" mode="OUT" optional="true"/>
</service>

But in the service method, there is this :
Map resp = ServiceUtil.returnSuccess();
resp.put("invoiceId", invoiceId);
resp.put("invoiceTypeId", invoiceType);
return resp;

And so it generates the following error :
(OUT) Required test error: org.ofbiz.service.ServiceValidationException: Unknown parameter found: [createInvoiceForOrderAllItems.invoiceTypeId]