OFBiz
  1. OFBiz
  2. OFBIZ-2531

Enhancements in Trainings under HR module

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: humanres
    • Labels:
      None
    • Environment:

      Windows XP

      Description

      Hi users,

      We are working on enhancement of "Trainings" under HR module. We have modified the existing Trainings tab by adding a Training calendar to it. We have planned to integrate following functionalities by doing some modifications and enhancements under HR module

      In GlobalHRSettings tab

      1. Added "Training Types" tab where admin can add/delete/update the types of trainings available in an organization.

      2. Implemented the functionality of "Training Calendar" where training schedules are maintained. All the trainings are listed with their names, from/thru date and target audience. Admin can create/update/delete any calendar entry.

      In Trainings tab

      1. Added "Trainings" sub-tab where employee can apply for available trainings. Approver/Admin can assign any training from training calendar to the employee.

      2. Added "Trainings Status" tab where employee/approver can check their training request status. Approver/Admin can approve/reject requested trainings

      We would like to upload the implemented trainings patch ASAP. Before uploading patch we would like to discuss our approach with community members.

      Any comments/suggestions on this would be appreciated.

      Regards
      Simranjeet Singh
      iLabs, L & T Infotech Ltd.
      Mumbai.

      1. ASF.LICENSE.NOT.GRANTED--Trng Write Up.txt
        2 kB
        srikanth.jagannadhula
      2. HR_Training_improvements.patch
        12 kB
        Simranjeet Singh
      3. HR_Trainings.patch
        84 kB
        Simranjeet Singh
      4. HR_Trainings.patch
        105 kB
        Simranjeet Singh
      5. HR_Trainings.patch
        104 kB
        Simranjeet Singh

        Issue Links

          Activity

          Hide
          Simranjeet Singh added a comment -

          Hi

          In this patch we have Improve Trainings tab in the HR module.In Trainings we have created three menu-items.

          1. Training Schedule : Admin can create a Training schedule using available trainings.

          2. Training Calendar : Now when Training schedule is created, it is visible to all the employees. Interested employee can apply for the trainings from Calendar and sends it for approval to his superior. Superior can assign the trainings from Calendar to any employee.

          3. Training Status : Superior from his login can check who all have applied for Trainings. He can update the status and same is reflected at employee's end.
          Admin can check the Training status of all employees.

          There are three sub-tabs in it:
          My Training Status (Visible to Everyone)
          Training Approvals (visible to admin and superior only)
          All Training Status (visible to admin only)

          In GlobalHRSettings tab we have added "Training Types" tab where admin can add/delete/update the types of trainings available in an organization.

          We have also amended Trainings in HR-Employees tab and Party module with our implementation of Training Schedule.

          Thanks and Regards
          Simranjeet Singh
          iLabs, L & T Infotech Ltd.
          Mumbai

          Show
          Simranjeet Singh added a comment - Hi In this patch we have Improve Trainings tab in the HR module.In Trainings we have created three menu-items. 1. Training Schedule : Admin can create a Training schedule using available trainings. 2. Training Calendar : Now when Training schedule is created, it is visible to all the employees. Interested employee can apply for the trainings from Calendar and sends it for approval to his superior. Superior can assign the trainings from Calendar to any employee. 3. Training Status : Superior from his login can check who all have applied for Trainings. He can update the status and same is reflected at employee's end. Admin can check the Training status of all employees. There are three sub-tabs in it: My Training Status (Visible to Everyone) Training Approvals (visible to admin and superior only) All Training Status (visible to admin only) In GlobalHRSettings tab we have added "Training Types" tab where admin can add/delete/update the types of trainings available in an organization. We have also amended Trainings in HR-Employees tab and Party module with our implementation of Training Schedule. Thanks and Regards Simranjeet Singh iLabs, L & T Infotech Ltd. Mumbai
          Hide
          Sumit Pandit added a comment -

          Hello Simranjeet,

          Here are some comments based on OFBiz best practice, please make following correction -
          1) For UiLabels first please search and use for existing one.
          2) Do not use Tabs in your file (you have it in HumanResDemoData.xml)


          Thanks
          Sumit Pandit

          Show
          Sumit Pandit added a comment - Hello Simranjeet, Here are some comments based on OFBiz best practice, please make following correction - 1) For UiLabels first please search and use for existing one. 2) Do not use Tabs in your file (you have it in HumanResDemoData.xml) – Thanks Sumit Pandit
          Hide
          Simranjeet Singh added a comment -

          Hi

          Comments given by Sumit Pandit have been implemented and incorporated in the patch attached.

          Thanks and Regards
          Simranjeet Singh
          iLabs, L & T Infotech Ltd.
          Mumbai

          Show
          Simranjeet Singh added a comment - Hi Comments given by Sumit Pandit have been implemented and incorporated in the patch attached. Thanks and Regards Simranjeet Singh iLabs, L & T Infotech Ltd. Mumbai
          Hide
          Simranjeet Singh added a comment -

          Hi All

          I had attached HR Trainings patch few days back. But, I have not got any response from a long time. Kindly revert on this issue.

          Regards
          Simranjeet Singh
          iLabs, L & T Infotech Ltd.
          Mumbai.

          Show
          Simranjeet Singh added a comment - Hi All I had attached HR Trainings patch few days back. But, I have not got any response from a long time. Kindly revert on this issue. Regards Simranjeet Singh iLabs, L & T Infotech Ltd. Mumbai.
          Hide
          Hans Bakker added a comment -

          A nice enhancement to the HR component where you follow the Datamodel resourcebook closely. You have also added some entities not mentioned in the book.

          1. Trainingshedule: i would suggest here to use the workeffort for that. as a bonus for you you can use the existing calendar day/week/month and icalendar facilites already created there. Party assignment is also present together with the workeffortstatus which can be used.
          Empoyees see the upcoming training in their calendar and via the icalendar function can see it even on their mobile phone.

          Regards,
          Hans

          Show
          Hans Bakker added a comment - A nice enhancement to the HR component where you follow the Datamodel resourcebook closely. You have also added some entities not mentioned in the book. 1. Trainingshedule: i would suggest here to use the workeffort for that. as a bonus for you you can use the existing calendar day/week/month and icalendar facilites already created there. Party assignment is also present together with the workeffortstatus which can be used. Empoyees see the upcoming training in their calendar and via the icalendar function can see it even on their mobile phone. Regards, Hans
          Hide
          Simranjeet Singh added a comment -

          Hi Hans

          Thanks for reviewing our patch. As you have suggested we have thought of two approaches:

          1. We can use existing Work Effort entity instead of Training Schedule without changing our screen design.

          2. We can use Calendar screens(work effort), and will rework and re-use these screens in HR module.

          So, What would you suggest , which approach we should follow ?

          Regards
          Simranjeet Singh
          iLabs, L & T Infotech Ltd.
          Mumbai.

          Show
          Simranjeet Singh added a comment - Hi Hans Thanks for reviewing our patch. As you have suggested we have thought of two approaches: 1. We can use existing Work Effort entity instead of Training Schedule without changing our screen design. 2. We can use Calendar screens(work effort), and will rework and re-use these screens in HR module. So, What would you suggest , which approach we should follow ? Regards Simranjeet Singh iLabs, L & T Infotech Ltd. Mumbai.
          Hide
          Hans Bakker added a comment -

          ii is always better to use existing screens and extend on them. However sometimes they not fit very well so you need a redesign. You better judge what to do.
          What is the most important here is to use the workeffort entity and services, so you can use the calendar screens/prortlet on the HR data...

          Show
          Hans Bakker added a comment - ii is always better to use existing screens and extend on them. However sometimes they not fit very well so you need a redesign. You better judge what to do. What is the most important here is to use the workeffort entity and services, so you can use the calendar screens/prortlet on the HR data...
          Hide
          Simranjeet Singh added a comment -

          Hi Hans,

          As per your suggestion, we have made following implementations

          1. Used "WorkEffort" entity and work effort module calendar screens for implementing Training Calendar
          2. Assignment and Application of trainings using HumanRes services.
          3. While applying training, employee cannot request same training event again to same approver.

          Kindly review and revert if you have any suggestions.

          Regards:

          Simranjeet SIngh
          iLabs, L&T Infotech
          Mumbai

          Show
          Simranjeet Singh added a comment - Hi Hans, As per your suggestion, we have made following implementations 1. Used "WorkEffort" entity and work effort module calendar screens for implementing Training Calendar 2. Assignment and Application of trainings using HumanRes services. 3. While applying training, employee cannot request same training event again to same approver. Kindly review and revert if you have any suggestions. Regards: Simranjeet SIngh iLabs, L&T Infotech Mumbai
          Hide
          Hans Bakker added a comment -

          Hi Simranjeet,
          ok it is now a lot better, always first look what is there and try to use it even it need a modification.
          I loaded the patch here and have the following remarks:
          1. in profile the trainings button does not work
          2. when i add a training, where can i approve it?
          3. there is also a trainings assignment, where can i do that?
          4. in the calendar i can request a training?
          5. do not use the word skills in the training conditions, that is already used in a other meaning
          6. You delete previos screens related to training, can you tell me why they were not good and yours are better?

          can you have a look at this?

          Regards,
          Hans

          Show
          Hans Bakker added a comment - Hi Simranjeet, ok it is now a lot better, always first look what is there and try to use it even it need a modification. I loaded the patch here and have the following remarks: 1. in profile the trainings button does not work 2. when i add a training, where can i approve it? 3. there is also a trainings assignment, where can i do that? 4. in the calendar i can request a training? 5. do not use the word skills in the training conditions, that is already used in a other meaning 6. You delete previos screens related to training, can you tell me why they were not good and yours are better? can you have a look at this? Regards, Hans
          Hide
          srikanth.jagannadhula added a comment -

          Hi ,

          Please ignore the attached text file, which was happened by mistake.Please delete if possible.

          Show
          srikanth.jagannadhula added a comment - Hi , Please ignore the attached text file, which was happened by mistake.Please delete if possible.
          Hide
          Simranjeet Singh added a comment -

          Hi Hans

          Thanks for reviewing our patch. I hope following explaination will suffice all your queries.

          Introduction:
          Trainings in HR module includes Training Calendar where we can create new schedules from trainings available in an organization. Admin can assign trainings & employee can request for scheduled trainings. Employee can also check status of their training requests & assignments.

          Need of Trainings in HR:
          • Training and development of professionals fills up the skill gaps and further improve the levels of proficiency.
          • Training and development manages constantly changing business and industrial scenario and therefore, matches with the requirements or demands of changes on the organizations.
          • Creates a learning organization culture.
          • Organizational development: Organization decides to use certain initiatives and wants to train and develop a good number of people in the entire organization or the people in certain chosen departments or projects on those initiatives.
          • Prepares the organization to meet the needs of legal/statutory requirements.

          Features of Trainings:
          • New Trainings can be added/modified.
          • Trainings can be scheduled in the calendar.
          • Employees can apply to supervisor for available scheduled trainings but, cannot request same training event again to same approver
          • Admin can assign trainings to Employees.
          • Admin can approve/reject the trainings requested to him but, once rejected cannot be approved again.
          • Employees can check the status of their training requests and Trainings assigned to them.

          Road Ahead:
          Currently we have implemented Trainings under HR module. We are working on the implementation of Training calendar in profile tab of Employee. We are also planning to introduce trainer's information in training calendar.

          Regards:
          Simranjeet Singh
          iLabs, L & T Infotech Ltd.
          Mumbai.

          Show
          Simranjeet Singh added a comment - Hi Hans Thanks for reviewing our patch. I hope following explaination will suffice all your queries. Introduction : Trainings in HR module includes Training Calendar where we can create new schedules from trainings available in an organization. Admin can assign trainings & employee can request for scheduled trainings. Employee can also check status of their training requests & assignments. Need of Trainings in HR : • Training and development of professionals fills up the skill gaps and further improve the levels of proficiency. • Training and development manages constantly changing business and industrial scenario and therefore, matches with the requirements or demands of changes on the organizations. • Creates a learning organization culture. • Organizational development: Organization decides to use certain initiatives and wants to train and develop a good number of people in the entire organization or the people in certain chosen departments or projects on those initiatives. • Prepares the organization to meet the needs of legal/statutory requirements. Features of Trainings : • New Trainings can be added/modified. • Trainings can be scheduled in the calendar. • Employees can apply to supervisor for available scheduled trainings but, cannot request same training event again to same approver • Admin can assign trainings to Employees. • Admin can approve/reject the trainings requested to him but, once rejected cannot be approved again. • Employees can check the status of their training requests and Trainings assigned to them. Road Ahead : Currently we have implemented Trainings under HR module. We are working on the implementation of Training calendar in profile tab of Employee. We are also planning to introduce trainer's information in training calendar. Regards: Simranjeet Singh iLabs, L & T Infotech Ltd. Mumbai.
          Hide
          Simranjeet Singh added a comment -

          Hi Hans,

          We have completed the functionality of Training Calendar in Employee profile tab and will soon upload the updated patch. Hope to hear from you soon.

          Regards:
          Simranjeet Singh
          iLabs, L & T Infotech Ltd.
          Mumbai.

          Show
          Simranjeet Singh added a comment - Hi Hans, We have completed the functionality of Training Calendar in Employee profile tab and will soon upload the updated patch. Hope to hear from you soon. Regards: Simranjeet Singh iLabs, L & T Infotech Ltd. Mumbai.
          Hide
          Hans Bakker added a comment -

          Hi Simranjeet,

          i committed your patch on rev 802308 with minor changes. However it is not working complete yet:
          1. make sure your application works when i login as DemoEmployee, this party is however not allowed to login to HR, permissions need to be added for that so that only the calendar is visible. This is a first application within HR for employees....
          2. In the menu you cannot check on a userLogin NOT having a permission, only checks on available permissions are possible.

          even with these blocking problems I valued this contribution to be added to OFBiz, can you please correct these?

          Thank you for your valuable work.

          Show
          Hans Bakker added a comment - Hi Simranjeet, i committed your patch on rev 802308 with minor changes. However it is not working complete yet: 1. make sure your application works when i login as DemoEmployee, this party is however not allowed to login to HR, permissions need to be added for that so that only the calendar is visible. This is a first application within HR for employees.... 2. In the menu you cannot check on a userLogin NOT having a permission, only checks on available permissions are possible. even with these blocking problems I valued this contribution to be added to OFBiz, can you please correct these? Thank you for your valuable work.
          Hide
          Hans Bakker added a comment -

          Oh yes, what i forgot.

          I have added initial help screens, can you also provide more extensive text to explain how your contribution is working?

          check out the 'help' button in the top of the screen.

          Regards,
          Hans

          Show
          Hans Bakker added a comment - Oh yes, what i forgot. I have added initial help screens, can you also provide more extensive text to explain how your contribution is working? check out the 'help' button in the top of the screen. Regards, Hans
          Hide
          Simranjeet Singh added a comment -

          Hi Hans

          Thanks for appreciating and committing our work.
          We have added help screens for "Training calendar" and "Training approval".
          We have also made the desired changes you asked for and have attached the patch.

          Regards:

          Simranjeet Singh
          L&T Infotech
          Mumbai

          Show
          Simranjeet Singh added a comment - Hi Hans Thanks for appreciating and committing our work. We have added help screens for "Training calendar" and "Training approval". We have also made the desired changes you asked for and have attached the patch. Regards: Simranjeet Singh L&T Infotech Mumbai
          Hide
          Jacques Le Roux added a comment -

          Hi Simranjeet,

          A remark : please take care of removing also calls when you remove a service. For instance you forget createPersonTraining and updatePersonTraining. Done at revision: 817443

          Show
          Jacques Le Roux added a comment - Hi Simranjeet, A remark : please take care of removing also calls when you remove a service. For instance you forget createPersonTraining and updatePersonTraining. Done at revision: 817443
          Hide
          Jacques Le Roux added a comment -

          Hi,

          I'd like to know what had been commited and not in this issue, please comment.

          This question because I find this line

          • <request-map uri="createPersonTrainingExt">
            in both patch and, I'd like to know if we should review the last patch or not...

          Thanks

          Show
          Jacques Le Roux added a comment - Hi, I'd like to know what had been commited and not in this issue, please comment. This question because I find this line <request-map uri="createPersonTrainingExt"> in both patch and, I'd like to know if we should review the last patch or not... Thanks
          Hide
          Jacques Le Roux added a comment -

          Hi Simranjeet,

          I have commited HR_Training_improvements.patch in trunk at r826266. It was not to hard to merge so I merged by hand.

          I don't close this issue as some work is still pending. Hopefully you, or someone else, will complete it one day...

          Thanks

          Show
          Jacques Le Roux added a comment - Hi Simranjeet, I have commited HR_Training_improvements.patch in trunk at r826266. It was not to hard to merge so I merged by hand. I don't close this issue as some work is still pending. Hopefully you, or someone else, will complete it one day... Thanks
          Hide
          Jacques Le Roux added a comment -

          Other references from Party (notably sub-menu Training) have been removed at r826272

          I think in HumanResTypeData.xml a TRAINING_WAITING status is missing. Then StatusValidChange between TRAINING_STATUS, will also be needed...

          Show
          Jacques Le Roux added a comment - Other references from Party (notably sub-menu Training) have been removed at r826272 I think in HumanResTypeData.xml a TRAINING_WAITING status is missing. Then StatusValidChange between TRAINING_STATUS, will also be needed...
          Hide
          Jacques Le Roux added a comment -

          I have used "Trng Write Up.txt" file and Simranjeet Singh's above comment in a commit for the help system : r826406. It's a WIP

          Show
          Jacques Le Roux added a comment - I have used "Trng Write Up.txt" file and Simranjeet Singh's above comment in a commit for the help system : r826406. It's a WIP
          Hide
          Jacques Le Roux added a comment -

          Is this still a WIP?

          Show
          Jacques Le Roux added a comment - Is this still a WIP?

            People

            • Assignee:
              Hans Bakker
              Reporter:
              Simranjeet Singh
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development