[OFBIZ-2272] Secure URLs exceptions

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: Release Branch 09.04, Trunk
• Fix Version/s: Release Branch 09.04, Trunk
• Component/s: ALL COMPONENTS
• Sprint: Bug Crush Event - 21/2/2015
• Assignee: Jacques Le Roux
• Reporter: Jacques Le Roux
• Created: 05/Apr/09 13:26
• Updated: 05/Jun/10 18:11
• Resolved: 05/Jun/10 18:11

Description

Here are theexceptions I crossed during the recent secure URLs action. I put it here for convenience but I attached also the patch. Beware this patch is only for demontration (to show problems, not solutions) and should not be applied of course.

Index: applications/content/widget/cms/CMSScreens.xml
===================================================================
--- applications/content/widget/cms/CMSScreens.xml	(revision 761874)
+++ applications/content/widget/cms/CMSScreens.xml	(working copy)
@@ -171,7 +171,9 @@
                             <container style="screenlet-body">
                                 <section>
                                     <widgets>    
-                                        <link  text="${uiLabelMap.ContentGoToFind}" target="CMSContentFind?VIEW_INDEX=${CMSContentFindViewIndex}&amp;${CMSContentFindQueryString}" style="tabletext"/>
+                                        <link  text="${uiLabelMap.ContentGoToFind}" target="CMSContentFind" style="tabletext">
+                                        <parameter param-name="VIEW_INDEX" value="${CMSContentFindViewIndex}&amp;${CMSContentFindQueryString}"/>
+                                    </link>
                                         <include-form name="EditAddContentStuff" location="component://content/webapp/content/cms/CMSForms.xml" />
                                         <content content-id="${contentId}" enable-edit-name="notfound"  edit-request="EditAddSubContent?MASTER_contentId=${MASTER_contentId}&amp;MASTER_caContentIdTo=${MASTER_caContentIdTo}&amp;MASTER_caContentAssocTypeId=${MASTER_caContentAssocTypeId}&amp;MASTER_caFromDate=${MASTER_caFromDate}&amp;MASTER_drDataResourceId=${MASTER_drDataResourceId}&amp;caContentIdTo=${caContentIdTo}"/>
                                     </widgets>
@@ -217,7 +219,9 @@
                             <container style="screenlet-body">
                                 <section>
                                     <widgets>    
-                                        <link  text="${uiLabelMap.ContentGoToFind}" target="CMSContentFind?VIEW_INDEX=${CMSContentFindViewIndex}&amp;${CMSContentFindQueryString}" style="tabletext"/>
+                                        <link  text="${uiLabelMap.ContentGoToFind}" target="CMSContentFind" style="tabletext">
+                                        <parameter param-name="VIEW_INDEX" value="${CMSContentFindViewIndex}&amp;${CMSContentFindQueryString}"/>
+                                    </link>
                                         <include-form name="EditAddSubContentStuff" location="component://content/webapp/content/cms/CMSForms.xml" />
                                     </widgets>
                                 </section>
Index: applications/product/widget/facility/FacilityScreens.xml
===================================================================
--- applications/product/widget/facility/FacilityScreens.xml	(revision 761874)
+++ applications/product/widget/facility/FacilityScreens.xml	(working copy)
@@ -431,8 +431,12 @@
                                     <!--<link target="ViewFacilityInventoryByProductSimple" text="${uiLabelMap.CommonPrint}" style="buttontext">
                                         <parameter param-name="facilityId" from-field="facilityId"/>
                                     </link>-->
-                                    <link target="ViewFacilityInventoryByProductReport?${searchParameterString}" text="${uiLabelMap.CommonPrint}" style="buttontext"/>
-                                    <link target="ViewFacilityInventoryByProductExport?${searchParameterString}" text="${uiLabelMap.CommonExport}" style="buttontext"/>
+                                    <link target="ViewFacilityInventoryByProductReport" style="buttontext">
+                                        <parameter param-name="${searchParameterString}" text" value=""${uiLabelMap.CommonPrint}"/>
+                                    </link>
+                                    <link target="ViewFacilityInventoryByProductExport" style="buttontext">
+                                        <parameter param-name="${searchParameterString}" text" value=""${uiLabelMap.CommonExport}"/>
+                                    </link>
                                     <link target="InventoryItemTotals" text="${uiLabelMap.ProductInventoryItemTotals}" style="buttontext">
                                         <parameter param-name="facilityId" from-field="facilityId"/>
                                         <parameter param-name="action" value="Y"/>
Index: applications/product/widget/facility/ReportScreens.xml
===================================================================
--- applications/product/widget/facility/ReportScreens.xml	(revision 761874)
+++ applications/product/widget/facility/ReportScreens.xml	(working copy)
@@ -54,8 +54,12 @@
                             <label style="h1" text="${uiLabelMap.ProductInventoryByProduct} ${uiLabelMap.CommonFor} ${facility.facilityName}"/>
                         </container>
                         <container>
-                            <link target="ViewFacilityInventoryByProductReport?${searchParameterString}" text="${uiLabelMap.CommonPrint}" style="buttontext"/>
-                            <link target="ViewFacilityInventoryByProductExport?${searchParameterString}" text="${uiLabelMap.CommonExport}" style="buttontext"/>
+                            <link target="ViewFacilityInventoryByProductReport" style="buttontext">
+                                        <parameter param-name="${searchParameterString}" text" value=""${uiLabelMap.CommonPrint}"/>
+                                    </link>
+                            <link target="ViewFacilityInventoryByProductExport" style="buttontext">
+                                        <parameter param-name="${searchParameterString}" text" value=""${uiLabelMap.CommonExport}"/>
+                                    </link>
                         </container>
                         <container style="screenlet">
                             <container style="screenlet-title-bar">
Index: specialpurpose/assetmaint/widget/FacilityScreens.xml
===================================================================
--- specialpurpose/assetmaint/widget/FacilityScreens.xml	(revision 761874)
+++ specialpurpose/assetmaint/widget/FacilityScreens.xml	(working copy)
@@ -59,8 +59,12 @@
                             <!--<link target="ViewFacilityInventoryByProductSimple" text="${uiLabelMap.CommonPrint}" style="buttontext">
                                 <parameter param-name="facilityId" from-field="facilityId"/>
                             </link>-->
-                            <link target="ViewFacilityInventoryByProductReport?${searchParameterString}" text="${uiLabelMap.CommonPrint}" style="buttontext"/>
-                            <link target="ViewFacilityInventoryByProductExport?${searchParameterString}" text="${uiLabelMap.CommonExport}" style="buttontext"/>
+                            <link target="ViewFacilityInventoryByProductReport" style="buttontext">
+                                        <parameter param-name="${searchParameterString}" text" value=""${uiLabelMap.CommonPrint}"/>
+                                    </link>
+                            <link target="ViewFacilityInventoryByProductExport" style="buttontext">
+                                        <parameter param-name="${searchParameterString}" text" value=""${uiLabelMap.CommonExport}"/>
+                                    </link>
                         </container>
 
                         <include-form name="FindFacilityInventoryByProduct" location="component://product/webapp/facility/facility/FacilityForms.xml"/>
Index: specialpurpose/mypage/widget/MyPageMenus.xml
===================================================================
--- specialpurpose/mypage/widget/MyPageMenus.xml	(revision 761874)
+++ specialpurpose/mypage/widget/MyPageMenus.xml	(working copy)
@@ -126,7 +126,7 @@
         </menu-item>
         <menu-item name="help" title="${uiLabelMap.CommonHelp}" align-style="opposed">
             <condition><not><if-empty field="userLogin"/></not></condition>
-            <link target="http://docs.ofbiz.org/display/OFBENDUSER/My+Page?decorator=printable" url-mode="plain" target-window="new"/>
+            <link target="http://docs.ofbiz.org/display/OFBENDUSER/My+Page" url-mode="plain" target-window="new"/>
         </menu-item>
         <menu-item name="preferences" title="${uiLabelMap.CommonPreferences}" align-style="opposed">
             <condition>

Issue Links

• relates to: OFBIZ-2243 In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements