[OFBIZ-1712] Skip ".svn" subdirectories when searching for JAR files during ofbiz startup

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: Release Branch 4.0, Trunk
• Component/s: framework

Environment

n/a

• Assignee: Jacques Le Roux
• Reporter: Wai Tam
• Created: 18/Mar/08 03:50
• Updated: 08/Apr/08 14:43
• Resolved: 08/Apr/08 14:43

Description

During ofbiz startup, it looks for jar files in the /ofb/framework/base/lib.
I noticed that when it is iterating through this subdirectory, it looks into the ".svn" subdirectory as well. This sub directory should be skipped.

The files affected are shown below. I don't know why "CVS" string exists in the code. Perhaps its legacy code from way back.

/ofbiz/framework/base/src/base/org/ofbiz/base/container/ComponentContainer.java, line 182
change...
if (componentPath.isDirectory() && !sub.equals("CVS")) {
to...
if (componentPath.isDirectory() && !sub.equals("CVS") && !sub.equals(".svn")) {

/ofbiz/framework/base/src/start/org/base/start/Start.java, line 174:
change...
if (file.isDirectory() && !"CVS".equals(fileName) && recurse) {
to...
if (file.isDirectory() && !"CVS".equals(fileName) && !".svn".equals(fileName) && recurse) {

ofbiz-trunk/framework/shark/webapp/shark/repository - showRepository.ftl
There's an occurrence of "CVS" string as well. But I do not know Freemarker macros.