OFBiz
  1. OFBiz
  2. OFBIZ-1585

Credit card valdation does not work properly during anonymous quick checkout process

    Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Environment:

      Ubuntu 7.10, Firefox 2.0.0.11

    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      If a credit card is selected as payment method and process button is pressed without adding all mandatory fields of credit card, order will be summited despite showing the validation error on credit card and user have no choice of rectifying the validation errors.

      Screenshot is attached showing this behavior

      1. OFBIZ-1585.patch
        2 kB
        Jacques Le Roux
      2. OFBIZ-1585.patch
        4 kB
        Jagpreet Kaur
      3. credit-card-validation2.png
        120 kB
        Raj Saini
      4. credit-card-validation.png
        141 kB
        Raj Saini

        Activity

        Hide
        Raj Saini added a comment -

        First part of the screenshot showing validation errors

        Show
        Raj Saini added a comment - First part of the screenshot showing validation errors
        Hide
        Raj Saini added a comment -

        Second part of the attachment as it could not fit on single screen. Process button label is changed showing that form has submitted despite validation error

        Show
        Raj Saini added a comment - Second part of the attachment as it could not fit on single screen. Process button label is changed showing that form has submitted despite validation error
        Hide
        Jagpreet Kaur added a comment -

        Added a request to validate if payment method and shipping method is given by user , if not then return the last view

        Show
        Jagpreet Kaur added a comment - Added a request to validate if payment method and shipping method is given by user , if not then return the last view
        Hide
        Jacques Le Roux added a comment -

        Thanks Jagpreet

        I have replaces your file by a regular patch (before only the extension was wrong)

        Show
        Jacques Le Roux added a comment - Thanks Jagpreet I have replaces your file by a regular patch (before only the extension was wrong)
        Hide
        Jacques Le Roux added a comment -

        This sounds good to me (only reviewed, not tested)

        Show
        Jacques Le Roux added a comment - This sounds good to me (only reviewed, not tested)
        Hide
        Jagpreet Kaur added a comment -

        Thanks Jacques for changing the extension. I'am going to work a little more on this bug in some days.

        Show
        Jagpreet Kaur added a comment - Thanks Jacques for changing the extension. I'am going to work a little more on this bug in some days.
        Hide
        Jacques Le Roux added a comment -

        You mean there is still some work to do?

        Show
        Jacques Le Roux added a comment - You mean there is still some work to do?
        Hide
        Jagpreet Kaur added a comment -

        Yes, till now when the user not choose payment or shipping method same view is returned
        I think there should be some error message to be returned, and as its checkout process there should be thorough testing

        Show
        Jagpreet Kaur added a comment - Yes, till now when the user not choose payment or shipping method same view is returned I think there should be some error message to be returned, and as its checkout process there should be thorough testing
        Hide
        Jacques Le Roux added a comment -

        Good idea, thanks!

        Show
        Jacques Le Roux added a comment - Good idea, thanks!
        Hide
        Jagpreet Kaur added a comment -

        When a user will process order, without choosing a payment method or shipment method error message will return.

        Show
        Jagpreet Kaur added a comment - When a user will process order, without choosing a payment method or shipment method error message will return.
        Hide
        Divesh Dutta added a comment -

        Fix is committed in revision number 1735777 in trunk. Thanks Jagpreet for the patch and Late Raj Saini for reporting this issue.

        Show
        Divesh Dutta added a comment - Fix is committed in revision number 1735777 in trunk. Thanks Jagpreet for the patch and Late Raj Saini for reporting this issue.
        Hide
        Jacques Le Roux added a comment -

        Tests fails: reopen

        Show
        Jacques Le Roux added a comment - Tests fails: reopen
        Hide
        Jacques Le Roux added a comment -

        Reverted at r1736164

        Show
        Jacques Le Roux added a comment - Reverted at r1736164
        Hide
        Divesh Dutta added a comment - - edited

        Jacques Le Roux I ran all the tests locally and all tests were successful after applying this patch. Also there was no compile timer error. Should I commit the patch again ?

        Show
        Divesh Dutta added a comment - - edited Jacques Le Roux I ran all the tests locally and all tests were successful after applying this patch. Also there was no compile timer error. Should I commit the patch again ?
        Hide
        Divesh Dutta added a comment -

        After discussion with Jacques on chat we concluded that tests are running successfully locally, so Jacques will revert his commit 1736164 . Thanks Jacques Le Roux

        Show
        Divesh Dutta added a comment - After discussion with Jacques on chat we concluded that tests are running successfully locally, so Jacques will revert his commit 1736164 . Thanks Jacques Le Roux
        Hide
        Divesh Dutta added a comment -

        Jacques Le Roux I applied the wrong patch to run tests. Sorry for the noise. I can see the failure in test cases now. Will look into it .

        Show
        Divesh Dutta added a comment - Jacques Le Roux I applied the wrong patch to run tests. Sorry for the noise. I can see the failure in test cases now. Will look into it .
        Hide
        Jacques Le Roux added a comment -

        Thanks, Divesh, got the same conclusion here

        Show
        Jacques Le Roux added a comment - Thanks, Divesh, got the same conclusion here

          People

          • Assignee:
            Divesh Dutta
            Reporter:
            Raj Saini
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development

                Agile