Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-13143

Webtools FindGeneric, sort field is break on list

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      On webtools the FindGeneric screen (/webtools/entity/find/

      {entityName}

      ) have an issue with the sort order.

      After a search if you clic to sort the list, you lost the entityName and your search. The analyse look that come from the url encode (MacroFormRenderer.java:2141), who result a bad interpretation during ftl rendering.

      linkUrl = rh.makeLink(this.request, this.response, urlPath.concat(URLEncoder.encode(newQueryString, "UTF-8")));
      

      This has been introduce with jira OFBIZ-8302 for security reason.

      To solve this, we implement a new function on UtilCodec.java to ask it if we need to encode the url or not with the presence of the variable escapeUrlEncode.

      Like is test on root context, we need to set this variable on our code where we want to escape the encoding, just before call the MacroRenderer. This it not accessible from the request so no risk for the security origin fix.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nmalin Nicolas Malin
            nmalin Nicolas Malin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment