[OFBIZ-13015] Miss UI user message for projectmgr/control/MyTimesheet

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Abandoned
• Affects Version/s: Upcoming Branch
• Fix Version/s: Upcoming Branch
• Component/s: projectmgr
• Assignee: Unassigned
• Reporter: Jacques Le Roux
• Created: 12/Apr/24 16:07
• Updated: 11/Jun/24 11:42
• Resolved: 11/Jun/24 11:42

Description

Currently there is only a hard legible message for users without sufficient permissions (sorry in French):

ERROR MESSAGE

java.lang.IllegalArgumentException: Error running script at location [component://projectmgr/src/main/groovy/org/apache/ofbiz/projectmgr/EditWeekTimesheet.groovy]: org.apache.ofbiz.service.ExecutionServiceException: ERROR: Could not complete the Create Timesheet For This Week of no date provided, otherwise for a specific week TimesheetServices.xml#createTimesheetForThisWeek process [problem invoking the [createTimesheet] service with the map named [parameters] containing [{userLogin=[GenericEntity:UserLogin][createdStamp,2024-04-12 02:36:48.635(java.sql.Timestamp)][createdTxStamp,2024-04-12 02:36:48.551(java.sql.Timestamp)][currentPassword,

{SHA}

47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,null()][externalAuthId,null()][hasLoggedOut,null()][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2024-04-12 02:36:48.635(java.sql.Timestamp)][lastUpdatedTxStamp,2024-04-12 02:36:48.551(java.sql.Timestamp)][partyId,DemoAuditor(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,auditor(java.lang.String)], fromDate=2024-04-07 00:00:00.0, timeZone=sun.util.calendar.ZoneInfo[id="Etc/UTC",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null], partyId=DemoAuditor, locale=fr, thruDate=2024-04-13 23:59:59.0}]: Vous n'avez pas la permission sur le service createTimesheet, raison : Erreur de sécurité : pour exécuter createTimesheet vous devez avoir une des autorisations suivantes : ASSETMAINT_CREATE, ASSETMAINT_ADMIN]

Even if I think users can understand the meaning, it's not very clean

Issue Links

• links to: GitHub Pull Request #123