Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-12810

BuildBot status Badge, use a link to BuildBot pages rather than to images

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 22.01.01
    • 22.01.01
    • BuildBot
    • None

    Description

      At https://lists.apache.org/thread/8r81mbyg8291g0j2qlth3mttd3hosdg9 Daniel rightly suggested to link from main README file to BuildBot pages rather than to badges images that give no real information

      Attachments

        Activity

          danwatford Daniel Watford added a comment -

          Hi jleroux ,

           

          The SVG image for the badge refers to the ofbiz-framework build, but the link points to the framework+plugins build. These should match.

          danwatford Daniel Watford added a comment - Hi jleroux ,   The SVG image for the badge refers to the ofbiz-framework build, but the link points to the framework+plugins build. These should match.
          jleroux Jacques Le Roux added a comment - - edited

          Actually, as we can see for RAT and 22.01 branch the BB badges are all the same. Hence a new section I'll had for RAT just below the badges. But you are right, for the sake of consistence, I'll will change that.

          jleroux Jacques Le Roux added a comment - - edited Actually, as we can see for RAT and 22.01 branch the BB badges are all the same. Hence a new section I'll had for RAT just below the badges. But you are right, for the sake of consistence, I'll will change that.

          Mmm, I remember something now. There is no (easy?) mean to know if a RAT build has succeeded or not, but to get to the RAT page. I had a conversation about that at (and related) RAT-256

          jleroux Jacques Le Roux added a comment - Mmm, I remember something now. There is no (easy?) mean to know if a RAT build has succeeded or not, but to get to the RAT page. I had a conversation about that at (and related) RAT-256
          danwatford Daniel Watford added a comment -

          Hi jleroux ,

          I think I may be misunderstanding your message - apologies if that is the case.

          I haven't found any documentation regarding the implementation of build status badges, but I would have expected every builder to have its own build status badge. Based on the URL in README.adoc, I would have thought individual badges would be accessible for the various OFBiz builds at:

          danwatford Daniel Watford added a comment - Hi jleroux , I think I may be misunderstanding your message - apologies if that is the case. I haven't found any documentation regarding the implementation of build status badges, but I would have expected every builder to have its own build status badge. Based on the URL in README.adoc, I would have thought individual badges would be accessible for the various OFBiz builds at: https://ci2.apache.org/badges/ofbizTrunkFramework.svg https://ci2.apache.org/badges/ofbizTrunkFrameworkPlugins.svg https://ci2.apache.org/badges/ofbizTrunkFrameworkRat.svg https://ci2.apache.org/badges/ofbizBranch22Framework.svg https://ci2.apache.org/badges/ofbizBranch22FrameworkPlugins.svg ... etc ...

          Unfortunately not, as you can check. There are only badges for success, failure and errors builds IIRW.

          Moreover if you look at ofbizTrunkFrameworkRat you will see that it never fails. Same for other RAT builders: https://ci2.apache.org/#/builders/50 and https://ci2.apache.org/#/builders/52 (except initial config errors of mine)

          Once the builder is OK, only the information in the result page change, for instance: https://nightlies.apache.org/ofbiz/trunk/rat-output.html

          BTW could you please fix the missing, or not needed, ASL2 licences headers in trunk and 22.01?
          Remember that some files don't need a header, or it's the problem to put one there.
          You can then use https://github.com/apache/ofbiz-tools/blob/master/rat-excludes.txt

          jleroux Jacques Le Roux added a comment - Unfortunately not, as you can check. There are only badges for success, failure and errors builds IIRW. Moreover if you look at ofbizTrunkFrameworkRat you will see that it never fails. Same for other RAT builders: https://ci2.apache.org/#/builders/50 and https://ci2.apache.org/#/builders/52 (except initial config errors of mine) Once the builder is OK, only the information in the result page change, for instance: https://nightlies.apache.org/ofbiz/trunk/rat-output.html BTW could you please fix the missing, or not needed, ASL2 licences headers in trunk and 22.01? Remember that some files don't need a header, or it's the problem to put one there. You can then use https://github.com/apache/ofbiz-tools/blob/master/rat-excludes.txt

          Hi danwatford,

          BTW could you please fix the missing, or not needed, ASL2 licences headers in trunk and 22.01? Remember that some files don't need a header, or it's the problem to put one there. You can then use https://github.com/apache/ofbiz-tools/blob/master/rat-excludes.txt

          Any chances ? Or do you want that I handle it for you?

          jleroux Jacques Le Roux added a comment - Hi danwatford , BTW could you please fix the missing, or not needed, ASL2 licences headers in trunk and 22.01? Remember that some files don't need a header, or it's the problem to put one there. You can then use https://github.com/apache/ofbiz-tools/blob/master/rat-excludes.txt Any chances ? Or do you want that I handle it for you?
          danwatford Daniel Watford added a comment -

          Sorry, jleroux

          I thought I had addressed the license headers a while ago. I must have missed some.

          I'll take care of it.

           

          danwatford Daniel Watford added a comment - Sorry, jleroux .  I thought I had addressed the license headers a while ago. I must have missed some. I'll take care of it.  

          Great, thanks Daniel

          jleroux Jacques Le Roux added a comment - Great, thanks Daniel

          People

            jleroux Jacques Le Roux
            jleroux Jacques Le Roux
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: