[OFBIZ-12741] ModelPermission should handle error responses from permission-services

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 22.01.01
• Fix Version/s: 22.01.01
• Component/s: framework/service
• Assignee: Daniel Watford
• Reporter: Daniel Watford
• Created: 10/Jan/23 16:11
• Updated: 12/Jan/23 10:15
• Resolved: 12/Jan/23 10:15

Description

ModelPermission's evalPermissionService method will call a permission-service as part of checking whether a user is permitted to execute a service.

If the permission service returns an error response then a Null Pointer Exception will be thrown by evalPermissionService since the error response is not trapped.

Amend evalPermissionService to detect an error response from the permission service and return it unchanged to the caller.

Further, amend evalPermissionService to check for the presence of the hasPermission attribute in the response before attempting to retrieve and convert it to a boolean.

Issue Links

• links to: GitHub Pull Request #578