[OFBIZ-12731] Time zones always displayed using their daylight savings display name

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 18.12.06, 22.01.01
• Component/s: themes/helveticus, themes/rainbow
• Assignee: Unassigned
• Reporter: Daniel Watford
• Created: 31/Dec/22 19:21
• Updated: 11/Jan/24 16:50

Description

The timestamp displayed in the ofbiz footer will use the daylight savings display name variant, even when the current date is outside of the daylight savings period.

See footer of OFBiz: Katalogverwaltung: (apache.org).

At time of writing this description we are in December. Daylight savings will not begin until March, but the timezone description is reported as British Summer Time.

Similarly, on the ListTimezones page, https://demo-stable.ofbiz.apache.org/catalog/control/ListTimezones, we see that the 'Europe/London' timezone is also named as British Summer Time.

The incorrect display of timezone names when outside of a daylight savings period is due to themes/[rainbowstone|flatgrey|helveticus]/template/<includes/>Footer.ftl and themes/common-theme/template/includes/ListTimezones.ftl.

In these FTL file, there is a call to TimeZone#getDisplayName, passing a boolean to indicate whether the timezone name should refer to daylight savings. A true value is passed if the timezone is currently in a daylight savings period or will transition to daylight savings in future.

The logic should be changed to test the current time to see if daylight savings is in effect and alter the call to TimeZone#getDisplayName accordingly.

Issue Links

• depends upon: OFBIZ-12721 Replace all occurrences of java.util.TimeZone by java.time.ZoneId