Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Implemented
    • Upcoming Branch, 22.01.01
    • 22.01.01
    • BuildBot, Demo, GitHub
    • None
    • GitHub Action and BuildBot (ie OFBiz CI) and demos

    Description

      After several discussions on dev ML, we decided to use JDK 17 in our CI in place of JDK 11. JDK 11 is no longer freely supported in 2023. JDK 17 is a LTS version freely supported until 2026.  Another one is JDK 21 supported until 2028. For JDK 21, it's specifed at https://www.oracle.com/java/technologies/java-se-support-roadmap.html:

          • LTS/non-LTS designation and dates are subject to change.

      Using JDK 17 implies to use a Gradle version supporting it. The last one is currently 7.6.

      For demos this has also another implication. As we no longer support the 18.12 branch and it's still the current stable, we need to create a 23.01 branch to be the next demo, having the 22.01 branch being the new stable with all branches using JDK 17.

      It's better to do all that (CI and demos) in one well prepared step in order to avoid confusion and duplicate efforts.

      Attachments

        1. JDK 17.patch
          1 kB
          Jacques Le Roux
        2. GH action gradle.yaml 22.01.patch
          1 kB
          Jacques Le Roux
        3. GH action gradle.yaml.patch
          1 kB
          Jacques Le Roux
        4. Buildbot ofbiz.py-1.patch
          3 kB
          Jacques Le Roux

        Issue Links

          Activity

            Commit 110483791d1bf640fd15e2d5589c940239c3c444 in ofbiz-tools's branch refs/heads/master from Jacques Le Roux
            [ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=1104837 ]

            Improved: Use JDK 17 in GitHub Action, BuildBot (ie OFBiz CI) and demos (OFBIZ-12729)

            Uses "SDKMAN!" to handle different versions in demos.
            See https://lists.apache.org/thread/8xq5gzn4kgjqsw5748yvpxq1vqopcssx for details

            jira-bot ASF subversion and git services added a comment - Commit 110483791d1bf640fd15e2d5589c940239c3c444 in ofbiz-tools's branch refs/heads/master from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=1104837 ] Improved: Use JDK 17 in GitHub Action, BuildBot (ie OFBiz CI) and demos ( OFBIZ-12729 ) Uses "SDKMAN!" to handle different versions in demos. See https://lists.apache.org/thread/8xq5gzn4kgjqsw5748yvpxq1vqopcssx for details
            jleroux Jacques Le Roux added a comment - - edited

            All works and is ready here but the demos that are still using JDK 11 for now, for details see https://lists.apache.org/thread/dpys7b3v066d88swy9grc8r371110xds

            jleroux Jacques Le Roux added a comment - - edited All works and is ready here but the demos that are still using JDK 11 for now, for details see https://lists.apache.org/thread/dpys7b3v066d88swy9grc8r371110xds

            Commit 88a014296c0fe7ec1d010bfb836595003aef14c0 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
            [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=88a014296c ]

            Improved: Use JDK 17 in GitHub Action, BuildBot (ie OFBiz CI) and demos (OFBIZ-12729)

            This is only the GH actions file

            jira-bot ASF subversion and git services added a comment - Commit 88a014296c0fe7ec1d010bfb836595003aef14c0 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=88a014296c ] Improved: Use JDK 17 in GitHub Action, BuildBot (ie OFBiz CI) and demos ( OFBIZ-12729 ) This is only the GH actions file

            Commit 30a0ef12f4931067bb8d637bf8daf44dabfaf3dd in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux
            [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=30a0ef12f4 ]

            Improved: Use JDK 17 in GitHub Action, BuildBot (ie OFBiz CI) and demos (OFBIZ-12729)

            This is only the GH actions file

            jira-bot ASF subversion and git services added a comment - Commit 30a0ef12f4931067bb8d637bf8daf44dabfaf3dd in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=30a0ef12f4 ] Improved: Use JDK 17 in GitHub Action, BuildBot (ie OFBiz CI) and demos ( OFBIZ-12729 ) This is only the GH actions file

            Argh, wrong issue, reopening

            jleroux Jacques Le Roux added a comment - Argh, wrong issue, reopening

            There is a conflict for 22.01 with GH action gradle.yaml.patch, here the right patch: GH action gradle.yaml 22.01.patch

            jleroux Jacques Le Roux added a comment - There is a conflict for 22.01 with GH action gradle.yaml.patch, here the right patch: GH action gradle.yaml 22.01.patch

            Ah, Jira changed, it now adds a suffix number to patches instead of graying old ones.

            jleroux Jacques Le Roux added a comment - Ah, Jira changed, it now adds a suffix number to patches instead of graying old ones.

            Replace Buildbot ofbiz.py.patch we don't want to change 18.12. It needs to still use JDK 11. Here is the new patch [^Buildbot ofbiz.py.patch]

            jleroux Jacques Le Roux added a comment - Replace Buildbot ofbiz.py.patch we don't want to change 18.12. It needs to still use JDK 11. Here is the new patch [^Buildbot ofbiz.py.patch]

            Because of OFBIZ-12733, as I already suggested in dev ML, for 18.12, currently the stable demo, we will simply stop and comment it out with an explanation in https://ofbiz.apache.org/ofbiz-demos.html

            jleroux Jacques Le Roux added a comment - Because of OFBIZ-12733 , as I already suggested in dev ML, for 18.12, currently the stable demo, we will simply stop and comment it out with an explanation in https://ofbiz.apache.org/ofbiz-demos.html
            jleroux Jacques Le Roux added a comment - - edited

            For Gradle, as explained in OFBIZ-12400, devs locally can use: ./gradlew wrapper --gradle-version=7.6 --distribution-type=bin

            At OFBIZ-12400 I have attached OFBIZ-12400-windows.patch. It will allow Windows users to use init-gradle-wrapper batch to get Gradle 7.6 in released versions using JDK 17. The *.nix version remains to be done.

            Note: Apparently the curent Jira version has a problem handling links to a file in another Jira issue when using the Visual feature.

            jleroux Jacques Le Roux added a comment - - edited For Gradle, as explained in OFBIZ-12400 , devs locally can use: ./gradlew wrapper --gradle-version=7.6 --distribution-type=bin At OFBIZ-12400 I have attached OFBIZ-12400-windows.patch . It will allow Windows users to use init-gradle-wrapper batch to get Gradle 7.6 in released versions using JDK 17. The *.nix version remains to be done. Note: Apparently the curent Jira version has a problem handling links to a file in another Jira issue when using the Visual feature.

            Fortunately the changes are very small, see attached patches. Of course I have not tested anything since it needs to be pushed to be tested.

            jleroux Jacques Le Roux added a comment - Fortunately the changes are very small, see attached patches. Of course I have not tested anything since it needs to be pushed to be tested.

            People

              jleroux Jacques Le Roux
              jleroux Jacques Le Roux
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: