[OFBIZ-12628] MenuItem doesn't follow correctly extend information

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Upcoming Branch, 22.01.01
• Fix Version/s: 22.01.01
• Component/s: framework/widget
• Assignee: Nicolas Malin
• Reporter: Nicolas Malin
• Created: 31/May/22 15:24
• Updated: 15/Jul/22 12:41
• Resolved: 15/Jul/22 12:41

Description

When you use two menus where the second extend the first, menu item and menu link aren't propage correctly.

The menu items and menu link presents on the second menu already have the first menu on their model.

 

<menu name="FirstMenu" extends="CommonInlineBarMenu" extends-resource="component://common/widget/CommonMenus.xml">
    <menu-item name="MyItem">
        <link target="GoAction"/>
    </menu-item>
</menu>
<menu name="SecondMenu" extends="FirstMenu"/> 

The result, if during the rendering some information are generate from the menu, in the previous case, it's always the "FirstMenu" that would be use.

To solve it and don't break the thread safe pattern, I introduce two new constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and MenuLink in memory with the new parent.

Issue Links

• breaks: OFBIZ-12665 Calendar in Work Effort does not work