[OFBIZ-12455] Product inventory reservation places orders if quantityNotReserved !=0 and requireInventory=Y

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Trunk, 17.12.08, 18.12.01, 18.12.02, 18.12.03, Upcoming Branch
• Fix Version/s: 18.12.06, 22.01.01
• Component/s: ecommerce, order

Environment

Linux/Ubuntu 20.04 LTS, Java 8

• Assignee: Giulio Speri
• Reporter: Giulio Speri
• Created: 13/Dec/21 18:44
• Updated: 15/Oct/22 15:02
• Resolved: 07/Apr/22 21:50

Description

The service reserveProductInventoryByFacility (file InventoryReserveServices.xml) simply do nothing in case quantityNotReserved value is not 0, but (ProductStore) requireInventory = Y.

Now, no action is taken and quantityNotReserved is simply returned to the caller (ie: reserveStoreInventory).

In this scenario an order can be placed despite there is no available inventory to fulfill an order item, causing backorder (that we wanted to avoid setting requireInventory flag on the ProductStore to Y ).

 

<if-compare field="parameters.quantityNotReserved" operator="not-equals" value="0" type="BigDecimal">
  <if-compare field="parameters.requireInventory" operator="equals" value="Y">
    <!-- use this else pattern to accomplish the anything but Y logic, ie if not specified default to inventory NOT required -->
  <else> 

I checked the usage of the service around the project and it seems to me that we can make an important assertion:  we can consider that also  requireInventory flag of the ProductStore is Y.

 

This issue is strictly related to OFBIZ-12264 issue.

Issue Links

• fixes: OFBIZ-7789 ReserveStoreInventory with insufficient inventory