Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-11350 Checkstyle improvements
  3. OFBIZ-12340

Remove Checkstyle warning related to double parenthesis at start of lines

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Implemented
    • Trunk
    • None
    • None
    • None
    • OFBiz Community Day (May 2020), OFBiz Community Day (Aug 2020)

    Description

      At https://markmail.org/message/3mhzlqew3igad3r2 I reported an issue that I was not able to really qualify. After exchanging with a Checkstyle expert (see markmail thread) I was unable to find what in our checkstyle.xml file was wrongly throwing these warnings. I decided that there was no reason to throw those warnings. So I decided to put the SuppressionCommentFilter in our checkstyle.xml file and use
      CHECKSTYLE_OFF: ALMOST_ALL/CHECKSTYLE_ON: ALMOST_ALL around the concerned lines as documented here
      https://checkstyle.sourceforge.io/config_filters.html#SuppressionCommentFilter_Examples

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jleroux Jacques Le Roux
            jleroux Jacques Le Roux
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Agile

                Completed Sprints:
                OFBiz Community Day (May 2020) ended 29/May/20
                OFBiz Community Day (Aug 2020) ended 28/Aug/20
                View on Board

                Slack

                  Issue deployment