Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-12299

Jgrowl label are not well retrieved showing 'undefined' button

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      Thanks to Xin Wang comments in https://s.apache.org/trrkk we discover
      that label retrieval for json is not working. To easily reproduce checkout pr/318 and generate some errors :

       

      Attachments

        Activity

          I just join the patch of a fix, i let some time to review before commiting next week if ok.

          It can be applied above pr/318 to validate the fix.

           

          pgil Gil Portenseigne added a comment - I just join the patch of a fix, i let some time to review before commiting next week if ok. It can be applied above pr/318 to validate the fix.  

          Commit a37d5cc5d550835bb90d63578bbd91691443bd0b in ofbiz-framework's branch refs/heads/trunk from Gil Portenseigne
          [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a37d5cc ]

          Fixed: Jgrowl label are not well retrieved showing 'undefined' button (OFBIZ-12299)

          Thanks to Xin Wang comments in https://s.apache.org/trrkk we discover
          that label retrieval through javascript are not working.

          One example exists, but is not functionnal and do not use jgrowl.

          This commit allow jgrowl use directly from javascript (showjGrowlMessage(...))
          while making label retrieval synchronous for Jgrowl and fromDate/thruDate existing
          feature.

          Clean up showErrorAlertLoadUiLabel that became orphan.

          jira-bot ASF subversion and git services added a comment - Commit a37d5cc5d550835bb90d63578bbd91691443bd0b in ofbiz-framework's branch refs/heads/trunk from Gil Portenseigne [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a37d5cc ] Fixed: Jgrowl label are not well retrieved showing 'undefined' button ( OFBIZ-12299 ) Thanks to Xin Wang comments in https://s.apache.org/trrkk we discover that label retrieval through javascript are not working. One example exists, but is not functionnal and do not use jgrowl. This commit allow jgrowl use directly from javascript (showjGrowlMessage(...)) while making label retrieval synchronous for Jgrowl and fromDate/thruDate existing feature. Clean up showErrorAlertLoadUiLabel that became orphan.

          Push only in trunk yet since some improvment make it not trivial to backport on 18.12.

          pgil Gil Portenseigne added a comment - Push only in trunk yet since some improvment make it not trivial to backport on 18.12.

          People

            pgil Gil Portenseigne
            pgil Gil Portenseigne
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: