Details

    Description

      This is an umbrella tasks for minor or trivial changes in Helveticus theme

      Attachments

        There are no Sub-Tasks for this issue.

        Activity

          jleroux Jacques Le Roux added a comment - - edited

          I reopen, I found at least a case that needs some attention. I'll create subtasks and will keep open for a moment...

          jleroux Jacques Le Roux added a comment - - edited I reopen, I found at least a case that needs some attention. I'll create subtasks and will keep open for a moment...

          Commit fce5d349f590852dc6810b5385ec94b8496593cf in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
          [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fce5d34 ]

          Improved: Improve Helveticus theme (OFBIZ-12276)

          Tentative to fix issues reported by SonarCloud:
          Unexpected shorthand "margin" after "margin-right"
          Unexpected duplicate "padding"

          Also try changes for INFRA-22689
          "No status emails sent to commits@ofbiz.apache.org"

          jira-bot ASF subversion and git services added a comment - Commit fce5d349f590852dc6810b5385ec94b8496593cf in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fce5d34 ] Improved: Improve Helveticus theme ( OFBIZ-12276 ) Tentative to fix issues reported by SonarCloud: Unexpected shorthand "margin" after "margin-right" Unexpected duplicate "padding" Also try changes for INFRA-22689 "No status emails sent to commits@ofbiz.apache.org"

          I confirm Sonarcloud is OK

          jleroux Jacques Le Roux added a comment - I confirm Sonarcloud is OK

          Hi All,

          I wonder, should we not backport Helveticus "improvements" (often rather bugs) in 24.09 while still keeping Rainbow as default? If ever those "improvements" fixes prove to be bugs it should be easy to fix them. WDYT?

          jleroux Jacques Le Roux added a comment - Hi All, I wonder, should we not backport Helveticus "improvements" (often rather bugs) in 24.09 while still keeping Rainbow as default? If ever those "improvements" fixes prove to be bugs it should be easy to fix them. WDYT?

          jleroux so far the issues I've looked at only concerned Helveticus (I tried to reproduce with Rainbowstone). If I find a bug affecting both Helveticus and Rainbowstone I'll make sure to port the fix in Rainbowstone.

          FloMo Florian Motteau added a comment - jleroux so far the issues I've looked at only concerned Helveticus (I tried to reproduce with Rainbowstone). If I find a bug affecting both Helveticus and Rainbowstone I'll make sure to port the fix in Rainbowstone.

          jleroux sorry I added a new issue while you were closing its parent...

          FloMo Florian Motteau added a comment - jleroux sorry I added a new issue while you were closing its parent...

          Not a problem Florian, it's just cosmetic and does not prevent the theme to work. We can continue to make it default.

          jleroux Jacques Le Roux added a comment - Not a problem Florian, it's just cosmetic and does not prevent the theme to work. We can continue to make it default.

          Commit f28a7b364b08ae3e6b7b3eba32c2944f32c296d7 in ofbiz-framework's branch refs/heads/release24.09 from Jacques Le Roux
          [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f28a7b364b ]

          Completed: Improve Helveticus theme (OFBIZ-12276)

          This sets HELVETICUS_EMERALD as default theme. It follows the discussion at
          https://lists.apache.org/thread/47bg0tr4w15dj3o55gzrsb4chkj227hl

          I must say that I picked green (emerald) instead of blue (sapphire) used before
          because it's my favorite colour... as far as I can remember... (that's how
          favorite color works, right?)

          Note that we could say that view from space the earth is blue and that's what
          we (humanity) have most in common. But wait, I could say I prefer green because
          it's the origin of life. Without plants nothing would live on this earth. And
          it believe I also I like green, not not only because it's obviously life but
          it also reassures me anytime.

          Of course that's my choice and we can discuss it. Did we for blue in the past?

          jira-bot ASF subversion and git services added a comment - Commit f28a7b364b08ae3e6b7b3eba32c2944f32c296d7 in ofbiz-framework's branch refs/heads/release24.09 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f28a7b364b ] Completed: Improve Helveticus theme ( OFBIZ-12276 ) This sets HELVETICUS_EMERALD as default theme. It follows the discussion at https://lists.apache.org/thread/47bg0tr4w15dj3o55gzrsb4chkj227hl I must say that I picked green (emerald) instead of blue (sapphire) used before because it's my favorite colour... as far as I can remember... (that's how favorite color works, right?) Note that we could say that view from space the earth is blue and that's what we (humanity) have most in common. But wait, I could say I prefer green because it's the origin of life. Without plants nothing would live on this earth. And it believe I also I like green, not not only because it's obviously life but it also reassures me anytime. Of course that's my choice and we can discuss it. Did we for blue in the past?

          Commit 598d561a03b368c8cc21578085d4250094022339 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
          [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=598d561a03 ]

          Completed: Improve Helveticus theme (OFBIZ-12276)

          This sets HELVETICUS_EMERALD as default theme. It follows the discussion at
          https://lists.apache.org/thread/47bg0tr4w15dj3o55gzrsb4chkj227hl

          I must say that I picked green (emerald) instead of blue (sapphire) used before
          because it's my favorite colour... as far as I can remember... (that's how
          favorite color works, right?)

          Note that we could say that view from space the earth is blue and that's what
          we (humanity) have most in common. But wait, I could say I prefer green because
          it's the origin of life. Without plants nothing would live on this earth. And
          it believe I also I like green, not not only because it's obviously life but
          it also reassures me anytime.

          Of course that's my choice and we can discuss it. Did we for blue in the past?

          jira-bot ASF subversion and git services added a comment - Commit 598d561a03b368c8cc21578085d4250094022339 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=598d561a03 ] Completed: Improve Helveticus theme ( OFBIZ-12276 ) This sets HELVETICUS_EMERALD as default theme. It follows the discussion at https://lists.apache.org/thread/47bg0tr4w15dj3o55gzrsb4chkj227hl I must say that I picked green (emerald) instead of blue (sapphire) used before because it's my favorite colour... as far as I can remember... (that's how favorite color works, right?) Note that we could say that view from space the earth is blue and that's what we (humanity) have most in common. But wait, I could say I prefer green because it's the origin of life. Without plants nothing would live on this earth. And it believe I also I like green, not not only because it's obviously life but it also reassures me anytime. Of course that's my choice and we can discuss it. Did we for blue in the past?

          People

            jleroux Jacques Le Roux
            jleroux Jacques Le Roux
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: