Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-11823

Refactor PickListServices#isBinComplete method to remove unnecessary iterations

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Branch
    • Component/s: product/facility
    • Labels:
      None

      Description

      PickListServices#isBinComplete() is used to check if picklistBin is complete.

      This method reduces system performance when a picklistBin contains heavy no of items in it, this method iterator all the items to check the status of the item to validate if the bin is complete or not.

      Instead of iteration, we can add itemStatusId != PICKITEM_COMPLETED condition while fetching records from the entity using queryCount() method and if we found count then picklistBin is not complete.

      It can be a major performance factor on a production system working on heavy orders.

        Attachments

        1. OFBIZ-11823.patch
          2 kB
          Pawan Verma
        2. OFBIZ-11823.patch
          2 kB
          Pawan Verma

          Activity

            People

            • Assignee:
              pawan Pawan Verma
              Reporter:
              pawan Pawan Verma
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: