-
Type:
Sub-task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: Trunk
-
Fix Version/s: 18.12.01, Upcoming Branch
-
Component/s: None
-
Labels:None
-
Sprint:OFBiz Community Day (May 2020), OFBiz Community Day (Aug 2020)
The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors come among all still present.
I think we should rely on a Checkstyle pre-commit hook like https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit.
Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3
- links to