[OFBIZ-11064] Use Groovy Truth instead of UtilValidate Class in Groovy

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Component/s: ALL COMPONENTS
• Assignee: Jacques Le Roux
• Reporter: Pawan Verma
• Created: 25/May/19 08:36
• Updated: 11/Jan/22 09:37
• Resolved: 26/May/19 10:38

Description

As we all know, Groovy is a powerful language with great built-in functions. Groovy Truth[1] is one of them, which is not used properly in our code base. We have used UtilValidate Class to validate arguments for Empty or NotEmpty, which can easily be done in groovy with built-in functionality.
 
Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
 
Groovy Built-in Code: if (locations) { ... }
 
IMO, We should use this Groovy Truth feature instead of UtilValidate Class. Please let me know your thoughts on this. Thanks!
[1] - http://groovy-lang.org/semantics.html#Groovy-Truth
 
We need to careful for some points while we change this:
Like:
maxRetry = 0
if (!maxRetry)

{  // Not set, use a default  maxRetry = -1 }

Because groovy evaluates zero to be false, it wouldn't be possible to set
maxRetry to zero.  So it's best not to use groovy truth for null-checks on
numbers in some cases.