[OFBIZ-11041] Incorrect findByCount on DynamicView with groupBy and selected field

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 16.11.06, 18.12.01, 17.12.01, Upcoming Branch
• Component/s: framework
• Assignee: Nicolas Malin
• Reporter: Nicolas Malin
• Created: 17/May/19 15:15
• Updated: 17/May/19 15:52
• Resolved: 17/May/19 15:52

Description

When you create a DynamicView with group by function and you realize a delegator.findCountByCondition() with selected fields, the result was different than count each element returned by delegator.findList().

In cause :

Index: framework/entity/src/main/java/org/apache/ofbiz/entity/datasource/GenericDAO.java
@@ -1031,7 +1031,7 @@
 
         // GROUP BY clause for view-entity
         if (isGroupBy) {
-            modelViewEntity.colNameString(modelViewEntity.getGroupBysCopy(), sqlBuffer, " GROUP BY ", ", ", "", false);
+            modelViewEntity.colNameString(modelViewEntity.getGroupBysCopy(selectFields), sqlBuffer, " GROUP BY ", ", ", "", false);
         }

modelViewEntity.colNameString returns all grouped by fields for realize goup by closure and not only thegrouped by fields present on  selected fields.