Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-10929

Duplicate a ShoppingCartItem didn't propage OrderItemAttributes

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 16.11.05, 17.12.01, Trunk, 18.12.01
    • 16.11.06, 17.12.01, 18.12.01
    • order
    • None

    Description

      When you clone a ShoppingCartItem by constructor

      new ShoppingCartItem(ShoppingCartItem item)

      Values contains on list OrderItemAttributes aren't propage to the new shoppingCartItem due to (ShoppingCartItem.java:682)

      if (UtilValidate.isEmpty(item.getOrderItemAttributes())) {
       this.orderItemAttributes = new HashMap<>();
       this.orderItemAttributes.putAll(item.getOrderItemAttributes());
      }
      

      isEmpty instead of isNotEmpty

      Attachments

        Activity

          People

            nmalin Nicolas Malin
            nmalin Nicolas Malin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: