[OFBIZ-10929] Duplicate a ShoppingCartItem didn't propage OrderItemAttributes

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk, 17.12.01, 16.11.05, 18.12.01
• Fix Version/s: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01
• Component/s: order
• Assignee: Nicolas Malin
• Reporter: Nicolas Malin
• Created: 16/Apr/19 18:28
• Updated: 16/Apr/19 19:33
• Resolved: 16/Apr/19 19:33

Description

When you clone a ShoppingCartItem by constructor

new ShoppingCartItem(ShoppingCartItem item)

Values contains on list OrderItemAttributes aren't propage to the new shoppingCartItem due to (ShoppingCartItem.java:682)

if (UtilValidate.isEmpty(item.getOrderItemAttributes())) {
 this.orderItemAttributes = new HashMap<>();
 this.orderItemAttributes.putAll(item.getOrderItemAttributes());
}

isEmpty instead of isNotEmpty