[OFBIZ-10832] simpleTypeConvert always returns Null for Document, Document Type and Notation Node

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Release Branch 16.11, Release Branch 18.12, Release Branch 17.12, Trunk
• Fix Version/s: 16.11.06
• Assignee: Swapnil Mane
• Reporter: Swapnil Mane
• Created: 11/Feb/19 09:47
• Updated: 02/Oct/19 17:20
• Resolved: 13/Mar/19 12:49

Description

simpleTypeConvert always returns Null for Document, Document Type and Notation Node

The ObjectType.simpleTypeConvert method always returns null for Document, Document Type and Notation Node.

As per the current code, getTextContent() method is used get text content of the node and its descendants but the node.getTextContent() always return Null for the following Node type
DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1]

if (obj instanceof Node) {
    Node node = (Node) obj;
    String nodeValue =  node.getTextContent();
    if ("String".equals(type) || "java.lang.String".equals(type)) {
      return nodeValue;
    }
    return simpleTypeConvert(nodeValue, type, format, timeZone, locale, noTypeFail);
}

Since we can't get the text value of Document, Document Type and Notation Node, we should simply return the same object.

[1] https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent()

Issue Links

• is related to: OFBIZ-10712 Inconsistent behaviour of ServiceDispatcher.checkAuth