Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-10753

Improve error message page to support Theming

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      Currently when OFBiz raise an error, we use a jsp page to display it.

      On common-controler.xml :

      <errorpage>/error/error.jsp</errorpage>

      This method isn't support by the theming. I propose two improvements :

      • use FlexibleLocation to resolve the error page :
        <errorpage>component://common/webcommon/error/error.ftl</errorpage>
      • improve theme to support the error message page   
          <template name="screen" type="html" content-type="UTF-8" encoding="none" encoder="html" compress="false">
          <template-file widget="screen" location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
          <template-file widget="form" location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
          <template-file widget="tree" location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
          <template-file widget="menu" location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
        + <template-file widget="error" location="component://common-theme/template/ErrorPage.ftl"/>
        </template>

      By the way you can define your error page by the theme in first step and we would use the rendering type in future to display the error no only in html

        Attachments

        1. Sélection_224.png
          87 kB
          Nicolas Malin
        2. OFBIZ-10753.patch
          56 kB
          Nicolas Malin

          Activity

            People

            • Assignee:
              soledad Nicolas Malin
              Reporter:
              soledad Nicolas Malin
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: