[OFBIZ-10712] Inconsistent behaviour of ServiceDispatcher.checkAuth

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 16.11.06
• Component/s: framework
• Assignee: Deepak Dixit
• Reporter: Deepak Dixit
• Created: 14/Dec/18 13:14
• Updated: 11/Feb/19 09:58
• Resolved: 18/Dec/18 16:48

Description

We have checkAuth method in service dispatcher class, this method performs multiple auth related check.

if all checks passed it call the modelService.makeValid method to prepare service context (line#960) but this code executed only when service definition has a permission service call.

If service does not have any permission service call then it does not call the modelService.makeValid and this may cause the service validation issue unknown parameter found.

Ideally modelService.makeValid should call irrespective to permission service check.

Issue Links

• relates to: OFBIZ-10688 textareas do not save data, when visual-editor is used
• relates to: OFBIZ-10832 simpleTypeConvert always returns Null for Document, Document Type and Notation Node