[OFBIZ-10489] Unnecessary ship groups in orders

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Release Branch 18.12, Release Branch 17.12, Trunk
• Fix Version/s: 17.12.01, 18.12.01
• Component/s: order
• Flags: Patch
• Assignee: Akash Jain
• Reporter: Oleg Andreyev
• Created: 19/Jul/18 16:33
• Updated: 07/Feb/20 15:01
• Resolved: 07/Feb/20 13:27

Description

Under some conditions, checkout creates extra ship groups in the order.

Steps to reproduce:

1. create a couple of products P1 and P2 (just to get clear results).
2. create a new order and add 1 P1 and 1 P2
3. change quantity P1 to 2 (or both) and Recalculate Order (key step really)
4. finish checkout

You will see 2 order items linked with ship group 00001 and another ship group 00002 that should not have been created. You may see in the patch that the code address a ship group using index of the order item and the shopping cart creates new ship group if the index is greater than the number of existing groups. 

In one of my projects based on 16.11, I noticed even more serious trouble that takes place if both products are drop-shipping order but don't explain it here because it seems do not appear in the trunk.