[OFBIZ-10150] supplierProductId Should Have Consistent Types Across Entities.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Release Branch 16.11, Release Branch 18.12, Release Branch 17.12, Trunk, Upcoming Branch
• Fix Version/s: Upcoming Branch
• Component/s: order, product

Environment

all

• Assignee: Jacques Le Roux
• Reporter: jesse thomas
• Created: 08/Jan/18 17:47
• Updated: 20/Feb/24 08:47
• Resolved: 20/Feb/24 08:47

Description

During some data migration I hit an issue where my data for supplierProductId was too long. So I looked up the fields and noticed that the order item entity had a different type for the field than the supplier product entity. I think it would be a good idea to pick one so the two fields can be treated consistently. I would vote for id-long, but I think either way it would be good to have them be the same type. There are other fields that have this issue too if you are interested?

Thanks!

applications/datamodel/entitydef/order-entitymodel.xml:
<entity entity-name="OrderItem".......
<field name="supplierProductId" type="id-long"></field>

applications/datamodel/entitydef/product-entitymodel.xml:
<entity entity-name="SupplierProduct"......
<field name="supplierProductId" type="id"></field>