[ODFTOOLKIT-473] cache alien element and attribute class to make it faster in OdfXMLFactory

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.6.2-incubating
• Fix Version/s: 0.6.2-incubating
• Component/s: odfdom
• Labels: performance
• Assignee: Svante Schubert
• Reporter: fanliwen
• Created: 11/Apr/18 11:48
• Updated: 11/Apr/18 14:07

Description

Hi,

Class.forName may not be an efficient method. and in <code>org.odftoolkit.odfdom.pkg.OdfXMLFactory    line:153<code> Class, it use Class.forName to find the Element/Atrribute Class. The <code>classCache</code> map make it better to find the Class. But we need a cache for Alien Element/Atrribute Class too, otherwise it will find the same alien Class by Class.forName again and again. It take too much of CPU cycle.

It show you in the attachment which a snapshot by JProfiler.It call the Class.forName 39459 times to find the same Class.

And this is my pull request in GitHub: https://github.com/apache/odftoolkit/pull/3

Regards.

ravenq.