[ODE-800] Incorrect Hibernate QL clause in instance cleanup query

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.4, 2.0
• Fix Version/s: 1.3.4, 2.0-beta3
• Component/s: BPEL Runtime
• Assignee: Tammo van Lessen
• Reporter: Aaron Anderson
• Created: 07/Apr/10 01:01
• Updated: 13/Apr/10 20:03
• Resolved: 13/Apr/10 19:52

Description

When the ODE Runtime is configured to use hibernate and executes a CronJob to cleanup stale instances it sets the InstanceFilter pid QName value as part of the query

http://svn.apache.org/repos/asf/ode/branches/APACHE_ODE_1.X/bpel-runtime/src/main/java/org/apache/ode/bpel/engine/cron/RuntimeDataCleanupRunnable.java#restoreFromDetailsMap

However, in the hibernate QL the pi.process.id is queried by instead of the pi.process.processId and a ClassCastException is thrown

http://svn.apache.org/repos/asf/ode/branches/APACHE_ODE_1.X/dao-hibernate/src/main/java/org/apache/ode/daohib/bpel/CriteriaBuilder.java#buildHQLQuery

After changing

filters.append(" pi.process.id ").append(cmp).append(" :pid").append(m);

to
filters.append(" pi.process.processId ").append(cmp).append(" :pid").append(m);

The axis-war ProcessCronCleanupTest passed for me