ODE
  1. ODE
  2. ODE-405

ActivityRecoveryTest fails on some machines due to timing

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3.4
    • Component/s: Test environment
    • Labels:
      None

      Description

      The ActivityRecoveryTest fails on some machines due to timing. We should investigate why and try to reduce/eliminate the effects of timing.

        Activity

        Hide
        Hudson added a comment -

        Integrated in ODE-1.x #75 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/75/)
        : testFailureWithManualRecovery fix

        Show
        Hudson added a comment - Integrated in ODE-1 .x #75 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/75/ ) : testFailureWithManualRecovery fix
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in ODE-1 .x #72 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/72/ )
        Rafal Rusin made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ODE-1.x #70 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/70/)
        : testFailureWithManualRecovery NPE fix

        Show
        Hudson added a comment - Integrated in ODE-1 .x #70 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/70/ ) : testFailureWithManualRecovery NPE fix
        Rafal Rusin made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Rafal Rusin added a comment -

        There's one problem left with testFailureWithManualRecovery

        java.lang.NullPointerException
        at org.apache.ode.bpel.runtime.ActivityRecoveryTest.getRecoveriesInScope(ActivityRecoveryTest.java:431)
        at org.apache.ode.bpel.runtime.ActivityRecoveryTest.getRecoveries(ActivityRecoveryTest.java:415)
        at org.apache.ode.bpel.runtime.ActivityRecoveryTest.recover(ActivityRecoveryTest.java:398)
        at org.apache.ode.bpel.runtime.ActivityRecoveryTest.testFailureWithManualRecovery(ActivityRecoveryTest.java:111)
        at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39)

        Show
        Rafal Rusin added a comment - There's one problem left with testFailureWithManualRecovery java.lang.NullPointerException at org.apache.ode.bpel.runtime.ActivityRecoveryTest.getRecoveriesInScope(ActivityRecoveryTest.java:431) at org.apache.ode.bpel.runtime.ActivityRecoveryTest.getRecoveries(ActivityRecoveryTest.java:415) at org.apache.ode.bpel.runtime.ActivityRecoveryTest.recover(ActivityRecoveryTest.java:398) at org.apache.ode.bpel.runtime.ActivityRecoveryTest.testFailureWithManualRecovery(ActivityRecoveryTest.java:111) at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39)
        Hide
        Hudson added a comment -

        Integrated in ODE-1.x #68 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/68/)
        : ActivityRecoveryTest fails on some machines due to timing fix

        Show
        Hudson added a comment - Integrated in ODE-1 .x #68 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/68/ ) : ActivityRecoveryTest fails on some machines due to timing fix
        Rafal Rusin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Rafal Rusin made changes -
        Fix Version/s 1.3.4 [ 12314168 ]
        Fix Version/s 2.0 [ 12313503 ]
        Hide
        Rafal Rusin added a comment -

        There's still something wrong with timing. It passed in my local config however.

        java.lang.NullPointerException
        at org.apache.ode.bpel.runtime.ActivityRecoveryTest.getRecoveriesInScope(ActivityRecoveryTest.java:410)
        at org.apache.ode.bpel.runtime.ActivityRecoveryTest.getRecoveries(ActivityRecoveryTest.java:394)
        at org.apache.ode.bpel.runtime.ActivityRecoveryTest.recover(ActivityRecoveryTest.java:377)
        at org.apache.ode.bpel.runtime.ActivityRecoveryTest.testFailureWithFaultAction(ActivityRecoveryTest.java:124)
        at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39)

        Show
        Rafal Rusin added a comment - There's still something wrong with timing. It passed in my local config however. java.lang.NullPointerException at org.apache.ode.bpel.runtime.ActivityRecoveryTest.getRecoveriesInScope(ActivityRecoveryTest.java:410) at org.apache.ode.bpel.runtime.ActivityRecoveryTest.getRecoveries(ActivityRecoveryTest.java:394) at org.apache.ode.bpel.runtime.ActivityRecoveryTest.recover(ActivityRecoveryTest.java:377) at org.apache.ode.bpel.runtime.ActivityRecoveryTest.testFailureWithFaultAction(ActivityRecoveryTest.java:124) at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39)
        Hide
        Hudson added a comment -

        Integrated in ODE-1.x #48 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/48/)
        : ActivityRecoveryTest fails on some machines due to timing (fix by William McCusker)

        Show
        Hudson added a comment - Integrated in ODE-1 .x #48 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/48/ ) : ActivityRecoveryTest fails on some machines due to timing (fix by William McCusker)
        Rafal Rusin made changes -
        Assignee Rafal Rusin [ rrusin ]
        William McCusker made changes -
        Attachment ActivityRecoveryTest.patch [ 12431773 ]
        Hide
        William McCusker added a comment -

        Here is a patch that changes the test to poll for up to MAX_WAIT for an instance to reach a desired state or for recovery to become available.

        Show
        William McCusker added a comment - Here is a patch that changes the test to poll for up to MAX_WAIT for an instance to reach a desired state or for recovery to become available.
        Matthieu Riou made changes -
        Field Original Value New Value
        Fix Version/s 1.3 [ 12313165 ]
        Fix Version/s 2.0 [ 12313503 ]
        Alex Boisvert created issue -

          People

          • Assignee:
            Rafal Rusin
            Reporter:
            Alex Boisvert
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development