[OAK-9966] Internal code calls Node.isCheckedOut and VersionManager.isCheckedOut

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.46.0, 1.22.17
• Component/s: core, jcr
• Labels: performance
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 13/Oct/22 09:31
• Updated: 30/Aug/23 05:50
• Resolved: 18/Oct/22 06:44

Description

while investigating a report about performance issues in Oak i came across stacktraces reporting excessive permission evaluation during ReadOnlyVersionManager.isCheckedOut(Tree)

there are a couple of things that struck me and which might be valuable improvements:

Internal Calls to VersionManager.isCheckedOut(String)

• JCR call NodeImpl.isCheckedOut calls JCR API VersionManager.isCheckedOut(String path), i.e. forcing the Tree object to be accessed again, when it was already present with the NodeImpl
• JCR call NodeImpl.canAddMixin calls JCR API VersionManager.isCheckedOut(String path), i.e. forcing the Tree object to be accessed again, when it was already present with the NodeImpl
• ImporterImpl constructor calls JCR API VersionManager.isCheckedOut(String path), i.e. forcing the Tree object to be accessed again despite the fact that it has been obtained just before

Internal Calls to Node.isCheckedOut() which calls VersionManager.isCheckedOut(String)

• JCR call NodeImpl.setPrimaryType calls JCR API Node.isCheckedOut
• JCR call NodeImpl.addMixin calls JCR API Node.isCheckedOut
• JCR call NodeImpl.removeMixin calls JCR API Node.isCheckedOut
• Jackrabbit API call NodeImpl.setMixins calls JCR API Node.isCheckedOut
• JCR call QueryImpl.storeAsNode calls JCR API Node.isCheckedOut
• JCR call SessionImpl.hasCapability calls JCR API Node.isCheckedOut after having retrieved the node.- JCR call PropertyImpl.remove() calls JCR API Node.isCheckedOut on parent node
• internal call NodeImpl.internalSetProperty(String,Value,boolean) calls JCR API Node.isCheckedOut
• internal call NodeImpl.internalSetProperty(String,Value[],boolean) calls JCR API Node.isCheckedOut
• internal call NodeImpl.internalRemoveProperty calls JCR API Node.isCheckedOut
• internal call PropertyImpl.internalSetValue(Value) calls JCR API Node.isCheckedOut on parent node
• - internal call PropertyImpl.internalSetValue(Value[]) calls JCR API Node.isCheckedOut on parent node

ReadOnlyVersionManager.isCheckedOut(Tree)

• The implementation of ReadOnlyVersionManager.isCheckedOut(Tree) verifies that the passed tree exists despite the fact that most callers of this method have already verified that the tree exists (e.g. the node was retrieved through JCR API).
• The implementation will recursively walk up the hierarchy to check if any of the parents is check-in (again verifying the existence and accessibility of the parent, which in this case is likely not relevant as it is an internal call that doesn't leak any information if the parent tree is not readable to the editing session)

jhoh, mreutegg wdyt?

Issue Links

• links to: GitHub Pull Request #731
• links to: GitHub Pull Request #732

Sub-Tasks

• Benchmark for OAK-9966: Closed