[OAK-9897] SplitPersistence: FileReaper cannot finish cleanup

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.44.0
• Component/s: segment-tar
• Assignee: Julian Sedding
• Reporter: Julian Sedding
• Created: 10/Aug/22 15:56
• Updated: 21/Oct/22 10:02

Description

When running revision compaction (aka GC) on a setup with split persistence, it is possible that the "cleanup" phase identifies files from the read-only part of the persistence as redundant and submits them to the FileReaper for deletion.

However, the delete method of the SplitSegmentArchiveManager is implemented to return "false" when attempting the deletion of a file from the read-only persistence (which I would argue is correct). The FileReaper then re-adds the offending file to its queue in order to retry deleting it. Of course this fails again and so it can never finish and logs warnings for the files it cannot delete.

It should be possible to prevent deletion of read-only files in the first place. In fact, I think there is no need to mark and sweep them at all.

cc adulceanu