[OAK-9833] UpgradeIT fails on Java 17

• Type: Technical task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.44.0
• Component/s: segment-tar
• Assignee: Marcel Reutegger
• Reporter: Marcel Reutegger
• Created: 11/Jul/22 14:16
• Updated: 15/Jul/22 14:53
• Resolved: 11/Jul/22 16:03

Description

Multiple tests in UpgradeIT fail when run with Java 17.

E.g. UpgradeIT.openReadonlyDoesNotUpgradeStore() fails with:

java.lang.IllegalStateException: Cannot start readonly store from empty journal

	at org.apache.jackrabbit.oak.segment.file.ReadOnlyRevisions.bind(ReadOnlyRevisions.java:65)
	at org.apache.jackrabbit.oak.segment.file.ReadOnlyFileStore.bind(ReadOnlyFileStore.java:91)
	at org.apache.jackrabbit.oak.segment.file.FileStoreBuilder.buildReadOnly(FileStoreBuilder.java:494)
	at org.apache.jackrabbit.oak.segment.upgrade.UpgradeIT.openReadonlyDoesNotUpgradeStore(UpgradeIT.java:86)

The real problem is in setup(). Creating the Oak 1.6 repository fails silently, but running the command manually shows the reason of the failure:

Apache Jackrabbit Oak 1.6.2
Exception in thread "main" groovy.lang.MissingPropertyException: No such property: class for class: org.apache.jackrabbit.oak.console.GroovyConsole
	at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:53)
	at org.codehaus.groovy.vmplugin.v7.IndyGuardsFiltersAndSignatures.unwrap(IndyGuardsFiltersAndSignatures.java:177)
	at org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:232)
	at org.codehaus.groovy.tools.shell.Shell.<init>(Shell.groovy:35)
	at org.codehaus.groovy.tools.shell.Groovysh.<init>(Groovysh.groovy:92)
	at org.apache.jackrabbit.oak.console.GroovyConsole$OakSh.<init>(GroovyConsole.groovy:150)
	at org.apache.jackrabbit.oak.console.GroovyConsole.prepareShell(GroovyConsole.groovy:90)
	at org.apache.jackrabbit.oak.console.GroovyConsole.<init>(GroovyConsole.groovy:64)
	at org.apache.jackrabbit.oak.console.Console.main(Console.java:155)

It looks like the groovy version in oak-run 1.6.2 does not work well with Java 17.

Issue Links

• links to: GitHub Pull Request #619