[OAK-9819] Improve Node.hasProperty/getProperty and Node.hasNode/getNode combinations

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.42.0
• Fix Version/s: 1.44.0, 1.22.15
• Component/s: jackrabbit-api, jcr
• Assignee: Angela Schreiber
• Reporter: Joerg Hoh
• Created: 28/Jun/22 15:07
• Updated: 22/Mar/23 10:14
• Resolved: 13/Jul/22 14:13

Description

In many applications using JCR I see this pattern:

application code v1

if (jcrNode.hasProperty(PROP) {
  value = jcrNode.getProperty(PROP);
}

I checked the implementation behind and found that Oak's NodeImpl implements hasProperty almost identical to the getProperty with

node.getPropertyOrNull(oakPath) != null;

That means that the above mentioned JCR code snippet invokes node.getPropertyOrNull twice. This could be improved by exposing a new method getPropertyOrNull, in which the above code could be written like this:

application code v2

tmpProp = jcrNode.getPropertyOrNull(PROP);
if (tmpProp != null) {
  value = tmpProp;
}

In this case there just the jcrNode.getPropertyOrNull method would do a single call into call, saving us the overhead of a second if the property is there.

Of course this cannot go into the JCR Node interface, but we could extend the JackrabbitNode with this.

Issue Links

• is related to: SLING-11449 Use JackrabbitNode.getPropertyOrNull
• is related to: OAK-9845 Backport OAK-9819 to the Oak 1.22 branch
• relates to: JCR-4813 Implement new JackrabbitNode APIs
• links to: GitHub Pull Request #609